Skip to content
This repository
Browse code

Fix goto dash button

  • Loading branch information...
commit 2f2b1a274b522bdaddadc73e56c7e2df20d6885a 1 parent f8b5092
Jeremy Cutler authored October 11, 2012
2  chrome/manifest.json
... ...
@@ -1,6 +1,6 @@
1 1
 {
2 2
    "name":        "Missing e",
3  
-   "version":     "2.13.5",
  3
+   "version":     "2.13.6",
4 4
    "description": "Useful features and customizations for Tumblr.",
5 5
    "icons":       { "16": "identity/missinge16.png",
6 6
                     "48": "identity/missinge48.png",
BIN  core/gotoDashPost/goto.png
29  core/gotoDashPost/gotoDashPost.js
@@ -34,18 +34,14 @@ MissingE.packages.gotoDashPost = {
34 34
       var div = document.getElementsByTagName("div")[0];
35 35
       var controls = div.getElementsByTagName("a");
36 36
 
37  
-      for (i=0; noGoto && i<controls.length; i++) {
38  
-         var imgs = controls[i].getElementsByTagName('img');
39  
-         for (j=0; j<imgs.length; j++) {
40  
-            if (imgs[j].src ===
41  
-                extension.getURL('core/gotoDashPost/goto.png')) {
42  
-               noGoto = false;
43  
-               break;
44  
-            }
45  
-         }
46  
-      }
  37
+      noGoto = document.getElementById("MissingE_gotoDashPost_link") == null;
47 38
 
48 39
       if (noGoto) {
  40
+         extension.insertStyle("#MissingE_gotoDashPost_link { " +
  41
+            "padding-left:18px; } #MissingE_gotoDashPost_link::before { " +
  42
+            "background: url('" +
  43
+            extension.getURL('core/gotoDashPost/gotoIcon.png') +
  44
+            "') 4px 3px no-repeat; }");
49 45
          var last = controls[controls.length-1];
50 46
          var following = false;
51 47
          var you = true;
@@ -72,17 +68,8 @@ MissingE.packages.gotoDashPost = {
72 68
                                     pid);
73 69
             dashlnk.setAttribute('target', '_top');
74 70
             dashlnk.id = "MissingE_gotoDashPost_link";
75  
-            var icn = document.createElement('img');
76  
-            icn.style.width = '50px';
77  
-            icn.style.height='20px';
78  
-            icn.style.borderWidth='0';
79  
-            icn.style.display='block';
80  
-            icn.style.cssFloat='left';
81  
-            icn.style.cursor='pointer';
82  
-            icn.alt='To Dash';
83  
-            icn.setAttribute('src',
84  
-                             extension.getURL('core/gotoDashPost/goto.png'));
85  
-            dashlnk.appendChild(icn);
  71
+            dashlnk.className = "btn icon";
  72
+            dashlnk.textContent = "Dash";
86 73
             div.insertBefore(dashlnk,last);
87 74
          }
88 75
       }
BIN  core/gotoDashPost/gotoIcon.png
2  firefox/missinge/package.json
@@ -3,7 +3,7 @@
3 3
     "license": "GPL 3.0",
4 4
     "author": "Jeremy Cutler",
5 5
     "url": "http://missing-e.com",
6  
-    "version": "2.13.5",
  6
+    "version": "2.13.6",
7 7
     "fullName": "Missing e",
8 8
     "id": "jid0-0PGffAcVvhUBieFYkRVVc5w6lIU",
9 9
     "description": "Useful features and customizations for Tumblr.",
4  missinge.safariextension/Info.plist
@@ -13,9 +13,9 @@
13 13
 	<key>CFBundleInfoDictionaryVersion</key>
14 14
 	<string>6.0</string>
15 15
 	<key>CFBundleShortVersionString</key>
16  
-	<string>2.13.5</string>
  16
+	<string>2.13.6</string>
17 17
 	<key>CFBundleVersion</key>
18  
-	<string>213005</string>
  18
+	<string>213006</string>
19 19
 	<key>Chrome</key>
20 20
 	<dict>
21 21
 		<key>Database Quota</key>
2  missinge.safariextension/Settings.plist
@@ -52,7 +52,7 @@
52 52
 	</dict>
53 53
 	<dict>
54 54
 		<key>DefaultValue</key>
55  
-		<string>2.13.5</string>
  55
+		<string>2.13.6</string>
56 56
 		<key>Key</key>
57 57
 		<string>MissingE_version</string>
58 58
 		<key>Title</key>
BIN  resources/iframe_sprite.png
2  site/currentVersion.js
... ...
@@ -1 +1 @@
1  
-var currentVersion="2.13.5";
  1
+var currentVersion="2.13.6";
4  site/index.html
@@ -99,7 +99,7 @@
99 99
  <div id="uptodate"></div>
100 100
  <div id="notuptodate"></div>
101 101
 </div>
102  
-<div version="2.13.5" id="versioncheck" style="display:none"></div>
  102
+<div version="2.13.6" id="versioncheck" style="display:none"></div>
103 103
 <header>
104 104
  <nav>
105 105
   <div id="nav_bar">
@@ -136,7 +136,7 @@
136 136
    <span id="download_txt">Download</span>
137 137
    <span id="installed_txt" style="display:none;">Installed</span>
138 138
    <span id="update_txt" style="display:none;">Update</span>
139  
-   <span id="download_version">Version 2.13.5</span>
  139
+   <span id="download_version">Version 2.13.6</span>
140 140
   </a>
141 141
   <div id="download_info">
142 142
    By using this extension, you agree<br />
2  site/update.php
@@ -188,7 +188,7 @@ function(){return;}, loadChromeDownload);
188 188
  <div id="uptodate"></div>
189 189
  <div id="notuptodate"></div>
190 190
 </div>
191  
-<div version="2.13.5" id="versioncheck" style="display:none"></div>
  191
+<div version="2.13.6" id="versioncheck" style="display:none"></div>
192 192
 <header>
193 193
  <nav>
194 194
   <div id="nav_bar">

0 notes on commit 2f2b1a2

Please sign in to comment.
Something went wrong with that request. Please try again.