Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haxe 4 compilation errors, Unknown identifier : validate_config, start_profiler_ do_advance_frame #57

Closed
jcward opened this issue Oct 15, 2018 · 3 comments
Assignees

Comments

@jcward
Copy link
Owner

jcward commented Oct 15, 2018

When compiling with Haxe 4:

../../hxtelemetry/HxTelemetry.hx:132: characters 5-20 : Unknown identifier : validate_config
../../hxtelemetry/HxTelemetry.hx:144: characters 20-34 : Unknown identifier : start_profiler
../../hxtelemetry/HxTelemetry.hx:172: characters 5-21 : Unknown identifier : do_advance_frame

The issue is because of a change in static extension for Haxe 4, requiring a this. prefix on static extension for "this" class (see HaxeFoundation/haxe#6036 and HaxeFoundation/haxe#7190).

@jcward jcward self-assigned this Oct 15, 2018
@jcward
Copy link
Owner Author

jcward commented Oct 15, 2018

Ah, I was working on an old branch, already fixed by 6d1ec0d

@jcward jcward closed this as completed Oct 15, 2018
@jahndis
Copy link

jahndis commented Apr 26, 2020

Hey, just wanted to point out that this never made it into the latest version of hxtelemetry in haxelib. I was able to use haxelib git to use the master branch directly which works fine, but a regular install of the current latest version (0.3.5) still produces this error with the latest version of haxe (4.0.5 currently).
Not sure if master is in a state to be released? It's working for me right now fwiw. It might be worth updating the travis builds to run against the latest haxe version as well?

@jcward
Copy link
Owner Author

jcward commented Apr 27, 2020

That's weird -- in adef28a I updated haxelib.json to 0.4.0 with the above changes. I usually do that and deploy to haxelib at the same time. Huh, well, I just pushed the update to 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants