Add support for expandable tree view #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreepPork
reviewed
Apr 27, 2020
Co-Authored-By: Ralfs Garkaklis <ralfs@garkaklis.com>
|
omg 😍 this is incredible. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec for expandable tree view wasn't very clear as the images on the book don't show a mixed state in the tree view, and currently there also isn't support for icons.
I wonder if regular tree view and expandable tree aren't supposed to be mixed? Regardless, this is a step forward.
The minus and plus signs are probably better as icons.
summaryis intentional. It's currently inconsistent between Chrome (not reset) and Firefox (reset). Here I added the reset style, but am also happy to move them to.tree-view.