Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for expandable tree view #69

Merged
merged 3 commits into from Apr 27, 2020
Merged

Add support for expandable tree view #69

merged 3 commits into from Apr 27, 2020

Conversation

muan
Copy link
Contributor

@muan muan commented Apr 27, 2020

The spec for expandable tree view wasn't very clear as the images on the book don't show a mixed state in the tree view, and currently there also isn't support for icons.

I wonder if regular tree view and expandable tree aren't supposed to be mixed? Regardless, this is a step forward.

before after
non-expandable tree view tree view with expandable icons using details element

The minus and plus signs are probably better as icons.

⚠️ I am not sure if the current reset styles on summary is intentional. It's currently inconsistent between Chrome (not reset) and Firefox (reset). Here I added the reset style, but am also happy to move them to .tree-view.

docs/docs.css Outdated Show resolved Hide resolved
Co-Authored-By: Ralfs Garkaklis <ralfs@garkaklis.com>
@jdan
Copy link
Owner

jdan commented Apr 27, 2020

omg 😍 this is incredible. thank you

@jdan jdan merged commit 68deceb into jdan:master Apr 27, 2020
@muan muan deleted the details branch Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants