Link text error fix when textContent is null

[jasonruesch]

Handled when the textContent is passed into the isDescriptiveText function as undefined or null in the link-text plugin. This fixes the error "Unable to get property 'replace' of undefined or null reference"

[jdan]

This LGTM, thank you very much!

Out of curiosity, do you have an example of a page that throws this error? I have never seen it before and it might be worth sending a fix upstream as well.

[jasonruesch]

Let me prepare one for you and I’ll send it your way shortly.

— Jason

On Jul 22, 2015, at 9:33 AM, Jordan Scales notifications@github.com wrote:

This LGTM, thank you very much!

Out of curiosity, do you have an example of a page that throws this error? I have never seen it before and it might be worth sending a fix upstream as well.

—
Reply to this email directly or view it on GitHub #48 (comment).

[jasonruesch]

The error was caused by the following anchor tag:

As you can see, it has no text! Obviously, I’ll be fixing that in our system, but maybe the utility should’ve caught it rather than erring.

Thanks,

Jason

On Jul 22, 2015, at 9:33 AM, Jordan Scales notifications@github.com wrote:

This LGTM, thank you very much!

Out of curiosity, do you have an example of a page that throws this error? I have never seen it before and it might be worth sending a fix upstream as well.

—
Reply to this email directly or view it on GitHub #48 (comment).

[jasonruesch]

Maybe the fix should be earlier in the call stack. With the fix I submitted, it gives the following help text for the error:

"The text "null" is unclear without context and may be confusing to screen readers. Consider rearranging the tags or including special screen reader text.” The fix I’m thinking is that empty string is passed into the isDescriptiveText function instead of null from the validateTextContent function. Just a thought.

Thanks,

Jason

On Jul 22, 2015, at 9:33 AM, Jordan Scales notifications@github.com wrote:

This LGTM, thank you very much!

Out of curiosity, do you have an example of a page that throws this error? I have never seen it before and it might be worth sending a fix upstream as well.

—
Reply to this email directly or view it on GitHub #48 (comment).

[jdan]

Yep, I see it, thanks!

Per the instructions in CONTRIBUTING.md, we require contributors to sign our Contributor License Agreement before we can merge their code in. If you have any questions be sure to let me know!

The fix is fine where it is - I'll likely merge this onto a separate branch and add a custom error message.

[jdan]

Landed in de2534f.

Turns out LinkTextPlugin was getting a little stale, so I made some improvements in 3497428 and added some unit tests in 1c86829.

Thanks @jasonruesch! 🌟