Skip to content

Commit

Permalink
Merge pull request #1 from calmh/master
Browse files Browse the repository at this point in the history
Support searches among multiple archs
  • Loading branch information
jdel committed Jan 13, 2020
2 parents 1b86921 + 338a19e commit 20de5fc
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages.go
Expand Up @@ -56,7 +56,7 @@ func (p Packages) FilterByArch(query string) Packages {
output := Packages{}

for _, synoPkg := range p {
if synoPkg.Arch == query || synoPkg.familyOrArchMatch(query) || synoPkg.Arch == "noarch" {
if synoPkg.Arch == query || sliceOfStringsContains(strings.Fields(synoPkg.Arch), query) || synoPkg.familyOrArchMatch(query) || synoPkg.Arch == "noarch" {
output = append(output, synoPkg)
}
}
Expand Down
19 changes: 19 additions & 0 deletions packages_test.go
Expand Up @@ -5,6 +5,7 @@ import (
"os"
"path/filepath"
"sort"
"strings"
"testing"

syno "jdel.org/go-syno"
Expand All @@ -16,6 +17,7 @@ var pX8664,
pCedarview3,
pX86,
pEvansport,
pMulti,
p1,
p2 *syno.Package

Expand Down Expand Up @@ -56,6 +58,12 @@ func init() {
Arch: "cedarview",
Version: "1.1",
}
pMulti = &syno.Package{
Name: "multi-arch-package",
DisplayName: "Multi Arch Package",
Arch: "x86_64 apollolake broadwell",
Version: "1.1",
}
pX86 = &syno.Package{
Name: "x86-package",
Arch: "x86",
Expand Down Expand Up @@ -219,6 +227,17 @@ func TestFilterByArch(t *testing.T) {
}
}

func TestFilterByArchMulti(t *testing.T) {
pp := syno.Packages{pMulti}
archs := strings.Fields(pMulti.Arch)
for _, arch := range archs {
ppf := pp.FilterByArch(arch)
if len(ppf) != 1 {
t.Errorf("Expected 1 package to match %q but got %+v", arch, ppf)
}
}
}

func TestFilterByFirmware(t *testing.T) {
pp := syno.Packages{p1, p2}
ppf := pp.FilterByFirmware("6.1")
Expand Down

0 comments on commit 20de5fc

Please sign in to comment.