Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr outside range #442

Merged
merged 4 commits into from Feb 23, 2018

Conversation

Projects
None yet
2 participants
@tympollack
Copy link
Contributor

commented Feb 23, 2018

No description provided.

@@ -2694,7 +2698,10 @@ target axis: ${transformApp} / ${transformVersion} / ${transformCubeName}, user:
prInfo[PR_TXID] = cube.name.substring(3)
results.add(prInfo)
}
results.sort(true, {Map a, Map b -> Converter.convert(b[PR_REQUEST_TIME], Date.class) as Date <=> Converter.convert(a[PR_REQUEST_TIME], Date.class) as Date})
results.sort(true, { Map a, Map b ->
Converter.convert(b[PR_REQUEST_TIME], Date.class) as Date <=> Converter.convert(a[PR_REQUEST_TIME], Date.class) as Date ?:

This comment has been minimized.

Copy link
@jdereg

jdereg Feb 23, 2018

Owner

Can you change this line to:

Converter.convertToDate(b[PR_REQUEST_TIME) <=> Converter.convertToDate(a[PR_REQUEST_TIME]) ?: ...

The point being, if you use the version that has the data type in the name, you do not need to pass Date.class and more importantly, no need for the 'as Date' call.

This comment has been minimized.

Copy link
@tympollack

tympollack Feb 23, 2018

Author Contributor

Fixed, sorry didn't realize that was a thing.

@jdereg jdereg merged commit cacdd63 into jdereg:master Feb 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.