windowPreview: disconnect from window title changes on actor destroy #263

Merged
merged 1 commit into from Oct 20, 2017

Conversation

Projects
None yet
2 participants
Contributor

3v1n0 commented Oct 20, 2017

When a popup is destroyed, the window might still emit signals of
title changed, causing crashes in gnome-shell

We're getting multiple crash reports about this in both Ubuntu (https://pad.lv/1714989) and upstream GNOME (https://bugzilla.gnome.org/show_bug.cgi?id=788931)

windowPreview: disconnect from window title changes on actor destroy
When a popup is destroyed, the window might still emit signals of
title changed, causing crashes in gnome-shell

https://bugzilla.gnome.org/show_bug.cgi?id=788931

@jderose9 jderose9 merged commit cd3f713 into jderose9:master Oct 20, 2017

Owner

jderose9 commented Oct 20, 2017

Thank you, this is very appreciated!

Contributor

3v1n0 commented Oct 20, 2017

Thanks for merging. Please also backport this to the version in extensions.gnome.org as soon as you can, so we can filter out similar crashes we're getting also from people without this.

:)

Owner

jderose9 commented Oct 20, 2017

@3v1n0 I just submitted the newest version for review (though of course it doesn't necessarily mean every user will upgrade). Thanks!

https://extensions.gnome.org/review/7552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment