Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding authdb support #96

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

jakeorr commented Feb 14, 2014

Adding authdb option to constructor and pulling authdb from mongoose_connection options if it exists.

@jakeorr jakeorr referenced this pull request Feb 14, 2014

Closed

Ability to set auth options #85

Contributor

atnstefan commented Jun 5, 2014

Really good and needed change. But can you please add some unit tests?

jakeorr commented Jun 5, 2014

I will take another look at this soon. I believe that when I submitted this I wasn't sure how to test for this functionality.

@jdesboeufs jdesboeufs added the client label Dec 17, 2014

This is something I desperately need. Anyway I could help with expediting the PR merge @jakeorr, @snegrea, @jdesboeufs?

jakeorr commented Dec 19, 2014

@paambaati If you wanted to take a crack at writing tests that's all it's waiting for. I didn't have a chance at the time and then switched onto a non-mongo environment which I've been in for a while.

@jdesboeufs jdesboeufs added a commit that referenced this pull request Dec 24, 2014

@jdesboeufs jdesboeufs Rewrite MongoStore initialization
* Re-use existing or upcoming mongoose connection
* Re-use existing or upcoming node-mongodb-native connection
* Accept full-featured MongoDB connection strings + advanced options
* Compatible with legacy config
* Replace callback by `connected` event
* Add debug

Fix #51, #58, #62, #66, #70, #85, #94, #96, #115, #117, #120
Fix #124, #128, #129, #130, #131, #133, #134
ca40b78

@jdesboeufs jdesboeufs closed this Dec 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment