feat: add plugin for bizui using nutui #3318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthrough本次变更在 Changes
Sequence Diagram(s)sequenceDiagram
participant UserCode as 用户代码
participant BabelPlugin as babelComponentStyle 插件
participant FileSystem as 文件系统
UserCode->>BabelPlugin: 导入 NutUI 组件
BabelPlugin->>BabelPlugin: 检查导入声明
BabelPlugin->>FileSystem: 检查样式文件是否存在
FileSystem-->>BabelPlugin: 返回文件存在/不存在
alt 样式文件存在
BabelPlugin->>UserCode: 插入样式 import 声明
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15 分钟 Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
action:review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #3318 +/- ##
==========================================
Coverage 88.14% 88.14%
==========================================
Files 290 290
Lines 19110 19110
Branches 2960 2960
==========================================
Hits 16844 16844
Misses 2261 2261
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
🧹 Nitpick comments (8)
packages/nutui-inject-ui-styles/.gitignore (1)
1-3: 补充忽略构建产物目录Rollup 构建该子包时通常会生成
dist/或lib/等产物目录，当前.gitignore未覆盖，容易把编译结果误提交进仓库。建议顺便屏蔽常见日志与缓存文件。.idea/ .vscode/ node_modules/ +# 打包产物 +dist/ +lib/ +# 日志 & 缓存 +npm-debug.log* +yarn-error.log* +.DS_Storepackages/nutui-inject-ui-styles/rollup.config.js (1)
6-20: Rollup配置结构合理构建配置清晰合理，正确设置了外部依赖排除和TypeScript支持。建议为配置对象添加注释说明其用途，提高代码可读性。
可以考虑为base配置对象添加注释：
const base = { + // 排除 Taro 服务依赖，避免打包到最终产物中 external: ['@tarojs/service'], + // 使用 TypeScript 插件处理 .ts 文件 plugins: [ts()], }packages/nutui-inject-ui-styles/README.md (1)
21-37: 废弃的Vite插件配置说明可以优化既然Vite插件方法已经废弃，建议：
- 将废弃部分移到文档末尾或单独的"废弃功能"章节
- 明确说明废弃的原因和替代方案
- 考虑在未来版本中完全移除废弃内容
packages/nutui-inject-ui-styles/tsconfig.json (1)
1-27: TypeScript配置完整且合理TypeScript配置设置全面，正确继承了根配置并针对包的需求进行了定制。编译选项设置合理，支持源码映射和类型声明文件生成，与Rollup构建配置保持一致。
可以考虑添加
"strict": true来启用所有严格类型检查选项，替代单独设置多个严格选项："compilerOptions": { + "strict": true, "allowSyntheticDefaultImports": true, "experimentalDecorators": true, "moduleResolution": "node", - "noImplicitAny": false, - "noUnusedLocals": true, - "noUnusedParameters": true, "removeComments": false, "resolveJsonModule": true, "skipLibCheck": true, - "strictNullChecks": true,packages/nutui-inject-ui-styles/types/index.d.ts (1)
16-16: 考虑使用命名导出替代默认导出ESLint 提示不应使用 'default' 作为导出名称。虽然这在 TypeScript 中是有效的，但如果项目的 ESLint 规则要求避免这种模式，可以考虑使用命名导出。
-export { babelComponentStyle as default } +export { babelComponentStyle } +export default babelComponentStylepackages/nutui-inject-ui-styles/src/babel-component-style.ts (3)
5-109: 考虑将组件列表外部化以便于维护当前组件列表是硬编码的，包含 103 个组件。随着 NutUI 的发展，这个列表需要手动更新。建议：
- 将列表移至独立的配置文件
- 或从 NutUI 包中动态获取
- 或在 IOptions 中提供自定义组件列表的选项
建议创建一个独立的配置文件：
// components.config.ts export const DEFAULT_COMPONENTS = [ 'button', 'cell', // ... 其他组件 ] as const export type ComponentName = typeof DEFAULT_COMPONENTS[number]然后在主文件中导入：
+import { DEFAULT_COMPONENTS } from './components.config' + -const list = [ - 'button', - // ... 所有组件 -] +const list = DEFAULT_COMPONENTS
127-128: 改进错误日志记录使用
console.log记录警告信息不够规范。建议使用更合适的日志级别或允许用户配置日志行为。-console.log(`warn: cannot reslove ${realNamePackage}`) +console.warn(`[nutui-inject-ui-styles] Cannot resolve package: ${realNamePackage}`)或者添加日志配置选项：
interface IOptions { // ... 现有字段 onWarn?: (message: string) => void } // 使用时 const warn = options.onWarn || console.warn warn(`[nutui-inject-ui-styles] Cannot resolve package: ${realNamePackage}`)
139-150: 考虑缓存文件存在性检查结果每次导入都会进行同步文件系统访问（
accessSync），这可能影响构建性能。建议添加缓存机制。// 在模块级别添加缓存 const styleFileCache = new Map<string, boolean>() // 在检查文件时使用缓存 function checkStyleFile(path: string): boolean { if (styleFileCache.has(path)) { return styleFileCache.get(path)! } try { accessSync(path) styleFileCache.set(path, true) return true } catch { styleFileCache.set(path, false) return false } } // 使用缓存的版本 if (checkStyleFile(importpath)) { const importCss = t.importDeclaration([], t.stringLiteral(importpath)) const programPath = path.findParent((path) => path.isProgram()) programPath.unshiftContainer('body', importCss) }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
packages/nutui-inject-ui-styles/dist/index.jsis excluded by!**/dist/**packages/nutui-inject-ui-styles/dist/index.js.mapis excluded by!**/dist/**,!**/*.map
📒 Files selected for processing (9)
packages/nutui-inject-ui-styles/.gitignore(1 hunks)packages/nutui-inject-ui-styles/README.md(1 hunks)packages/nutui-inject-ui-styles/package.json(1 hunks)packages/nutui-inject-ui-styles/rollup.config.js(1 hunks)packages/nutui-inject-ui-styles/src/babel-component-style.ts(1 hunks)packages/nutui-inject-ui-styles/src/index.ts(1 hunks)packages/nutui-inject-ui-styles/src/type.ts(1 hunks)packages/nutui-inject-ui-styles/tsconfig.json(1 hunks)packages/nutui-inject-ui-styles/types/index.d.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: oasis-cloud
PR: jdf2e/nutui-react#2700
File: src/packages/animatingnumbers/animatingnumbers.harmony.css:25-32
Timestamp: 2024-11-06T05:56:06.800Z
Learning: 在优化 NutUI React 动画性能时，添加 `will-change` 属性可能会对布局产生影响，需要谨慎使用。
📚 Learning: 在优化 nutui react 动画性能时，添加 `will-change` 属性可能会对布局产生影响，需要谨慎使用。...
Learnt from: oasis-cloud
PR: jdf2e/nutui-react#2700
File: src/packages/animatingnumbers/animatingnumbers.harmony.css:25-32
Timestamp: 2024-11-06T05:56:06.800Z
Learning: 在优化 NutUI React 动画性能时，添加 `will-change` 属性可能会对布局产生影响，需要谨慎使用。
Applied to files:
packages/nutui-inject-ui-styles/README.mdpackages/nutui-inject-ui-styles/src/babel-component-style.ts
📚 Learning: 在`trendarrow`组件（`src/packages/trendarrow/trendarrow.taro.tsx`）中，css变量在鸿蒙系统（harmony os）中可能未被完全支持，导致兼容...
Learnt from: oasis-cloud
PR: jdf2e/nutui-react#2540
File: src/packages/trendarrow/trendarrow.taro.tsx:29-30
Timestamp: 2024-11-06T02:16:07.069Z
Learning: 在`TrendArrow`组件（`src/packages/trendarrow/trendarrow.taro.tsx`）中，CSS变量在鸿蒙系统（Harmony OS）中可能未被完全支持，导致兼容性问题。因此，使用硬编码的十六进制颜色值可以确保在鸿蒙系统上的正确显示。
Applied to files:
packages/nutui-inject-ui-styles/README.mdpackages/nutui-inject-ui-styles/types/index.d.tspackages/nutui-inject-ui-styles/src/type.tspackages/nutui-inject-ui-styles/src/babel-component-style.ts
📚 Learning: when changes are made to the `filelist` state in the `src/packages/uploader/uploader.taro.tsx` file,...
Learnt from: Alex-huxiyang
PR: jdf2e/nutui-react#2416
File: src/packages/uploader/uploader.taro.tsx:230-230
Timestamp: 2024-07-05T02:58:57.992Z
Learning: When changes are made to the `fileList` state in the `src/packages/uploader/uploader.taro.tsx` file, ensure to generate unit tests to cover these changes.
Applied to files:
packages/nutui-inject-ui-styles/tsconfig.json
🧬 Code Graph Analysis (3)
packages/nutui-inject-ui-styles/src/index.ts (2)
packages/nutui-inject-ui-styles/types/index.d.ts (1)
babelComponentStyle(16-16)packages/nutui-inject-ui-styles/src/babel-component-style.ts (1)
babelComponentStyle(168-172)
packages/nutui-inject-ui-styles/types/index.d.ts (2)
packages/nutui-inject-ui-styles/src/type.ts (1)
IOptions(1-6)packages/nutui-inject-ui-styles/src/babel-component-style.ts (1)
babelComponentStyle(168-172)
packages/nutui-inject-ui-styles/src/babel-component-style.ts (3)
packages/nutui-inject-ui-styles/dist/index.js (1)
list(26-129)packages/nutui-inject-ui-styles/src/type.ts (1)
IOptions(1-6)src/utils/taro/platform.ts (1)
harmony(3-7)
🪛 ESLint
packages/nutui-inject-ui-styles/types/index.d.ts
[error] 16-16: 'default' is restricted from being used as an exported name.
(no-restricted-exports)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build
- GitHub Check: lint
- GitHub Check: test
🔇 Additional comments (3)
packages/nutui-inject-ui-styles/src/type.ts (1)
1-6: 接口设计合理，HarmonyOS兼容性考虑周到这个接口设计清晰简洁，特别是针对鸿蒙系统CSS变量不支持的问题提供了专门的处理方案。注释说明了
style属性的作用，这与之前学习到的鸿蒙系统CSS变量兼容性问题一致。packages/nutui-inject-ui-styles/src/index.ts (1)
1-3: 入口文件实现简洁清晰作为包的主入口文件，实现简洁明了，遵循了标准的模块导出模式。
packages/nutui-inject-ui-styles/package.json (1)
30-35: 确认并完善 Taro v4 兼容性依赖由于已将
@tarojs/service升级至 v4（含 Webpack5、插件化架构、生命周期及样式处理等破坏性变更），请务必确认并调整以下内容：
- 本包是否仅面向 Taro v4 设计？若是，请在 README 或 peerDependencies 中明确标注最低版本。
- 是否引入并声明了对应框架插件（如
@tarojs/plugin-framework-react、@tarojs/plugin-framework-vue2或@tarojs/plugin-framework-vue3）？- 对于 Vue2/React 项目，是否在 devDependencies 中添加了必要的编译依赖：
- Vue2：
@vue/babel-preset-jsx- React：
@pmmmwh/react-refresh-webpack-plugin、react-refresh- 如需保留对 Taro v3 的兼容性，请评估并区分版本策略（降级依赖或双版本支持）。
| { | ||
| "name": "@nutui/inject-ui-styles", | ||
| "version": "0.0.1", | ||
| "description": "", |
There was a problem hiding this comment.
🛠️ Refactor suggestion
请填写缺失的包元数据字段
包的 description、author、homepage 字段为空，repository 和 bugs 的 URL 也未填写。这些信息对于包的文档和维护很重要，建议补充完整。
- "description": "",
+ "description": "Babel plugin for injecting NutUI component styles automatically",
"keywords": [
"Taro",
"Plugin"
],
- "author": "",
- "homepage": "",
+ "author": "NutUI Team",
+ "homepage": "https://github.com/jdf2e/nutui-react/tree/main/packages/nutui-inject-ui-styles",
"license": "MIT",
"main": "dist/index.js",
"typings": "types/index.d.ts",
"files": [
"dist",
"index.js",
"types"
],
"repository": {
"type": "git",
- "url": ""
+ "url": "https://github.com/jdf2e/nutui-react.git"
},
"scripts": {
"build": "rollup -c",
"dev": "rollup -c -w"
},
"bugs": {
- "url": ""
+ "url": "https://github.com/jdf2e/nutui-react/issues"
},Also applies to: 9-10, 21-22, 28-29
🤖 Prompt for AI Agents
In packages/nutui-inject-ui-styles/package.json at lines 4, 9-10, 21-22, and
28-29, the package metadata fields such as description, author, homepage,
repository URL, and bugs URL are missing or empty. Fill in these fields with
accurate and complete information relevant to the package to improve
documentation and maintenance. Ensure the description briefly explains the
package purpose, author includes contact or name, homepage points to the project
site, and repository and bugs URLs link to the correct source and issue tracker
locations.
Comment on lines
+14
to
+18
| "files": [ | ||
| "dist", | ||
| "index.js", | ||
| "types" | ||
| ], |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
验证 files 数组中的路径配置
files 数组同时包含了 "dist" 和 "index.js"。如果 index.js 实际上位于 dist 目录下（作为 main 入口），这个配置可能是冗余的。请确认 index.js 文件的实际位置。
🏁 Script executed:
#!/bin/bash
# 检查 index.js 文件的位置
fd -t f "^index\.js$" packages/nutui-inject-ui-styles --max-depth 2Length of output: 115
删除冗余的 files 配置
packages/nutui-inject-ui-styles/package.json 中的 files 数组包含了 "index.js"，但实际上该项目根目录下并不存在 index.js，只有 dist/index.js 会被打包。请将 "index.js" 从 files 中移除，以避免发布时出现遗漏或误导。
需要修改的文件：
- packages/nutui-inject-ui-styles/package.json
建议改动：
- "files": [
- "dist",
- "index.js",
- "types"
- ],
+ "files": [
+ "dist",
+ "types"
+ ],🤖 Prompt for AI Agents
In packages/nutui-inject-ui-styles/package.json around lines 14 to 18, the
"files" array includes "index.js" which does not exist in the project root and
may cause confusion or packaging errors. Remove the "index.js" entry from the
"files" array so that only existing paths like "dist" and "types" are included
for packaging.
Comment on lines
+11
to
+19
| ```js | ||
| const injectUIStyles = require('@nutui/inject-ui-styles') | ||
|
|
||
| { | ||
| [ | ||
| [injectUIStyles({})] | ||
| ] | ||
| } | ||
| ``` |
There was a problem hiding this comment.
文档中的使用示例与实际导出不匹配
文档中的使用示例存在严重问题：示例中使用的是 injectUIStyles，但根据 src/index.ts 文件，包实际导出的是 babelComponentStyle。这会导致用户按照文档使用时出现运行时错误。
需要修正使用示例：
-const injectUIStyles = require('@nutui/inject-ui-styles')
+const babelComponentStyle = require('@nutui/inject-ui-styles')
{
[
- [injectUIStyles({})]
+ [babelComponentStyle]
]
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| ```js | |
| const injectUIStyles = require('@nutui/inject-ui-styles') | |
| { | |
| [ | |
| [injectUIStyles({})] | |
| ] | |
| } | |
| ``` | |
| const babelComponentStyle = require('@nutui/inject-ui-styles') | |
| { | |
| [ | |
| [babelComponentStyle] | |
| ] | |
| } |
🤖 Prompt for AI Agents
In packages/nutui-inject-ui-styles/README.md around lines 11 to 19, the usage
example incorrectly references injectUIStyles, but the actual export from
src/index.ts is babelComponentStyle. Update the example code to use
babelComponentStyle instead of injectUIStyles to match the real export and
prevent runtime errors for users following the documentation.
Comment on lines
+118
to
+119
| // 检查是否已经插入过或者有其他条件判断 | ||
| // if (state.file.get('hasInsertedImport')) return |
There was a problem hiding this comment.
启用重复导入预防机制
代码中注释掉了防止重复插入样式的逻辑。如果不启用，可能会导致：
- 同一样式文件被多次导入
- 构建产物体积增大
- 潜在的样式冲突
建议启用并完善这个机制：
ImportDeclaration(path) {
if (path.node.source.value === pName && path.node.specifiers.length) {
- // 检查是否已经插入过或者有其他条件判断
- // if (state.file.get('hasInsertedImport')) return
+ // 获取已插入的样式集合
+ const insertedStyles = path.hub.file.metadata.insertedStyles || new Set()
+
const realNamePackage = nodepath.normalize(cName)
// ... 其他代码
path.node.specifiers.forEach((specifier) => {
const name = specifier.imported.name.toLowerCase()
+
+ // 检查是否已经插入过该组件的样式
+ if (insertedStyles.has(name)) return
+
// ... 其他代码
try {
accessSync(importpath)
const importCss = t.importDeclaration([], t.stringLiteral(importpath))
const programPath = path.findParent((path) => path.isProgram())
programPath.unshiftContainer('body', importCss)
+
+ // 记录已插入的样式
+ insertedStyles.add(name)
} catch (e) {
/* empty */
}
})
- // 设置一个标记，防止重复插入
- // state.file.set('hasInsertedImport', true)
+
+ // 保存插入记录
+ path.hub.file.metadata.insertedStyles = insertedStyles
}
}Also applies to: 151-153
🤖 Prompt for AI Agents
In packages/nutui-inject-ui-styles/src/babel-component-style.ts around lines
118-119 and 151-153, the code that prevents duplicate style imports is commented
out, which can cause multiple imports of the same style, increasing build size
and causing style conflicts. Re-enable this duplicate import prevention by
uncommenting and properly implementing the check using
state.file.get('hasInsertedImport') or a similar mechanism to track if the style
has already been inserted, and return early if so.
Comment on lines
+160
to
+166
| function harmony() { | ||
| return (process.env.TARO_ENV as any).indexOf('harmony') > -1 | ||
| } | ||
|
|
||
| function dynamic() { | ||
| return (process.env.TARO_ENV as any).indexOf('dynamic') > -1 | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
改进环境检测函数的类型安全性和健壮性
当前实现存在以下问题：
- 使用
as any失去类型安全 - 未处理环境变量未定义的情况
- 使用
indexOf而非更现代的方法
function harmony() {
- return (process.env.TARO_ENV as any).indexOf('harmony') > -1
+ const env = process.env.TARO_ENV || ''
+ return env.toLowerCase().includes('harmony')
}
function dynamic() {
- return (process.env.TARO_ENV as any).indexOf('dynamic') > -1
+ const env = process.env.TARO_ENV || ''
+ return env.toLowerCase().includes('dynamic')
}另外，考虑到 src/utils/taro/platform.ts 中已有类似的 harmony() 函数，建议复用现有实现以保持一致性。
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| function harmony() { | |
| return (process.env.TARO_ENV as any).indexOf('harmony') > -1 | |
| } | |
| function dynamic() { | |
| return (process.env.TARO_ENV as any).indexOf('dynamic') > -1 | |
| } | |
| function harmony() { | |
| const env = process.env.TARO_ENV || '' | |
| return env.toLowerCase().includes('harmony') | |
| } | |
| function dynamic() { | |
| const env = process.env.TARO_ENV || '' | |
| return env.toLowerCase().includes('dynamic') | |
| } |
🤖 Prompt for AI Agents
In packages/nutui-inject-ui-styles/src/babel-component-style.ts around lines 160
to 166, the environment detection functions use 'as any' which loses type
safety, do not handle undefined environment variables, and use outdated
'indexOf' for string checks. To fix this, remove 'as any', add checks to ensure
process.env.TARO_ENV is defined before calling methods on it, replace 'indexOf'
with the more modern 'includes' method, and refactor to reuse the existing
harmony() function from src/utils/taro/platform.ts to maintain consistency and
improve robustness.
Comment on lines
+168
to
+172
| export function babelComponentStyle( | ||
| options: IOptions = { cName: '@nutui/nutui-react-taro', pName: '' } | ||
| ) { | ||
| return injectCSS(options) | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
改进默认参数配置
默认的 pName 为空字符串，这意味着如果用户不提供此参数，插件将无法匹配任何导入。建议要么将其设为必需参数，要么提供有意义的默认值。
export function babelComponentStyle(
- options: IOptions = { cName: '@nutui/nutui-react-taro', pName: '' }
+ options: IOptions = {
+ cName: '@nutui/nutui-react-taro',
+ pName: '@nutui/nutui-react-taro' // 使用相同的默认值
+ }
) {
return injectCSS(options)
}或者将 pName 设为可选并在代码中处理：
export function babelComponentStyle(options: Partial<IOptions> = {}) {
const defaultOptions: IOptions = {
cName: '@nutui/nutui-react-taro',
pName: options.cName || '@nutui/nutui-react-taro'
}
return injectCSS({ ...defaultOptions, ...options })
}🤖 Prompt for AI Agents
In packages/nutui-inject-ui-styles/src/babel-component-style.ts around lines 168
to 172, the default parameter pName is an empty string, causing the plugin to
fail matching imports if the user does not provide it. To fix this, make pName
optional in the options parameter and assign it a meaningful default value
inside the function by merging user options with defaults, ensuring pName
defaults to a valid string like the default cName if not provided.
Comment on lines
+1
to
+6
| interface IOptions { | ||
| pName: string | ||
| cName: string | ||
| // 默认加载组件的 scss 样式文件，鸿蒙由于不支持 css 变量，优先加载无css 变量的 style.harmony.css 文件。 | ||
| style?: boolean | 'css' | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
避免接口定义重复
IOptions 接口在这里重复定义了（在 src/type.ts 中也有相同定义）。建议从 type.ts 导入而不是重复定义。
+import { IOptions } from './type'
+
-interface IOptions {
- pName: string
- cName: string
- // 默认加载组件的 scss 样式文件，鸿蒙由于不支持 css 变量，优先加载无css 变量的 style.harmony.css 文件。
- style?: boolean | 'css'
-}Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In packages/nutui-inject-ui-styles/types/index.d.ts lines 1 to 6, the IOptions
interface is redundantly defined here and also in src/type.ts. Remove this local
definition and instead import the IOptions interface from src/type.ts to avoid
duplication and maintain consistency.
Comment on lines
+7
to
+15
| declare function babelComponentStyle(options?: IOptions): ({ | ||
| types: t, | ||
| }: { | ||
| types: any | ||
| }) => { | ||
| visitor: { | ||
| ImportDeclaration(path: any): void | ||
| } | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
使用正确的 Babel 类型定义
参数 types: any 应该使用 Babel 提供的正确类型定义，以提高类型安全性。
+import type { PluginObj, types as BabelTypes } from '@babel/core'
+
-declare function babelComponentStyle(options?: IOptions): ({
- types: t,
-}: {
- types: any
-}) => {
- visitor: {
- ImportDeclaration(path: any): void
- }
-}
+declare function babelComponentStyle(options?: IOptions): (api: {
+ types: typeof BabelTypes
+}) => PluginObj需要在 package.json 中添加 @babel/core 的类型定义：
"devDependencies": {
"@types/babel__core": "^7.20.0",
// ... 其他依赖
}🤖 Prompt for AI Agents
In packages/nutui-inject-ui-styles/types/index.d.ts around lines 7 to 15, the
parameter types is currently typed as any, which reduces type safety. Replace
the any type with the correct Babel type definitions by importing the
appropriate types from @babel/core. Also, ensure that @types/babel__core is
added as a devDependency in package.json to provide these type definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
新功能
@nutui/inject-ui-styles包，用于自动注入 NutUI 组件样式，支持 HarmonyOS 和 React Native 等平台。文档
杂项
.gitignore、package.json、tsconfig.json、Rollup 构建配置等）。