Skip to content

Jeff Hardy jdhardy

Organizations

IronLanguages
Jeff Hardy
  • Jeff Hardy b901a02
    Merge remote-tracking branch 'paweljasinski/cp35126' into ipy-2.7-maint
  • Jeff Hardy 01f0535
    Merge remote-tracking branch 'paweljasinski/cp35116' into ipy-2.7-maint
  • 3 more commits »
jdhardy merged pull request IronLanguages/main#189
Jeff Hardy
fixed cp35126
1 commit with 1 addition and 1 deletion
jdhardy merged pull request IronLanguages/main#187
Jeff Hardy
fixed cp35116
1 commit with 92 additions and 16 deletions
Jeff Hardy
jdhardy merged pull request IronLanguages/main#186
Jeff Hardy
Fix broken command line in the `Makefile`.
1 commit with 3 additions and 3 deletions
jdhardy commented on pull request IronLanguages/main#186
Jeff Hardy

Thanks!

jdhardy commented on pull request IronLanguages/ironpython3#53
Jeff Hardy

One overall comment: try to avoid temp or tmp if you can. (I did this on my phone so apologies if some comments are unclear. Might as well get some…

Jeff Hardy

Hopefully that will be very soon :)

Jeff Hardy

Can you elaborate on why these are commented you?

Jeff Hardy

Do those messages match CPython?

Jeff Hardy

_step > 1?

Jeff Hardy

What does CPython do when comparing a range to a list?

Jeff Hardy

This whole section could be extracted to make it more clear that it's checking for to many elements. Also, the max specified somewhere?

Jeff Hardy

Need a better name than 'temp'.

jdhardy commented on pull request IronLanguages/ironpython3#51
Jeff Hardy

Is that in release mode or debug mode? Maybe .net bigint is particularly bad in debug or something. On Apr 6, 2014 10:27 AM, "Pawel Jasinski" notif…

Jeff Hardy
  • Jeff Hardy 7bec672
    Fix CP#35099: int type missing __eq__ method
jdhardy commented on pull request IronLanguages/dlr#1
Jeff Hardy

lgtm!

jdhardy commented on pull request IronLanguages/ironpython3#51
Jeff Hardy

I was thinking if it was only a 2-3x difference it might be OK but 10x is just crazy. Since there's no actual math going on it must all be in alloc…

Jeff Hardy
int/long Unification
jdhardy commented on pull request IronLanguages/ironpython3#51
Jeff Hardy

Given that it'll be a new DLR version making the same is probably fine, but with dynamic being supported on iOS I'm beginning to wonder if supporti…

jdhardy commented on pull request IronLanguages/ironpython3#45
Jeff Hardy

I'd prefer a separate PR if possible.

Jeff Hardy
PEP 3100 -- Miscellaneous Python 3.0 Plans
jdhardy commented on pull request IronLanguages/ironpython3#48
Jeff Hardy

lgtm!

jdhardy commented on pull request IronLanguages/ironpython3#45
Jeff Hardy

Some of this stuff is going to be inefficient (range() needs to be an iterator, not list) or wrong (the int/long changes) until more of it is imple…

Jeff Hardy

Double str here.

jdhardy commented on pull request IronLanguages/ironpython3#46
Jeff Hardy

The only thing in nt._have_functions in CPython 3.3 is MS_WINDOWS. It looks like have_functions is only used for filling out the `os.supports*` fie…

Jeff Hardy
Jeff Hardy
  • Jeff Hardy db624a6
    Handle any capitalization of NUL in os.open.
Something went wrong with that request. Please try again.