Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tests #34

Merged
merged 1 commit into from Nov 28, 2018

Conversation

@vexx32
Copy link
Contributor

commented Nov 28, 2018

  • Improve consistency in quoting, capitalization, and parameter names
  • Use more appropriate Should parameters
  • Use It -TestCases where appropriate
  • Use verbose variable names
  • Use BeforeAll {} blocks where appropriate
  • Move Mocks to the top of the Describe or Context as they are scoped to that context even when declared inside an It
  • Improved consistency in style of It naming

Recommendations post-PR:

  1. Separate out tests for each module command into its own test file
  2. Idk probably some other stuff I'll remember later so consider this a placeholder for now
Update Tests
* Improve consistency in quoting, capitalization, and parameter names
* Use more appropriate `Should` parameters
* Use `It -TestCases` where appropriate
* Use verbose variable names
* Use `BeforeAll {}` blocks where appropriate
* Move `Mock`s to the top of the `Describe` or `Context` as they are scoped to that context even when declared inside an `It`
* Improved consistency in style of `It` naming

Recommendations post-PR:

1. Separate out tests for each module command into its own test file
2. Idk probably some other stuff I'll remember later so consider this a placeholder for now
@jdhitsolutions

This comment has been minimized.

Copy link
Owner

commented Nov 28, 2018

I was admittedly lazy and in a hurry when I created my tests. Thanks for this much needed cleanup.

@jdhitsolutions jdhitsolutions merged commit 31de017 into jdhitsolutions:master Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.