Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update the icons with new outline style icons (provided by VS Code) #460

Closed
hologerry opened this issue Oct 9, 2019 · 2 comments
Closed

Please update the icons with new outline style icons (provided by VS Code) #460

hologerry opened this issue Oct 9, 2019 · 2 comments
Labels
enhancement New feature or request
Milestone
0.15.8

Comments

@hologerry
Copy link
Contributor

hologerry commented Oct 9, 2019 •
edited

Please update the icons in extension with the vscode-icons.

Screen Shot 2019-10-09 at 23 34 36

Screen Shot 2019-10-10 at 00 10 53

Screen Shot 2019-10-10 at 00 11 02

Screen Shot 2019-10-10 at 00 12 33

Screen Shot 2019-10-10 at 00 11 12

I tried with replacing these svgs, but the endpoint (globe) icon does not work.

Screen Shot 2019-10-10 at 00 20 50

Thanks a lot!
@jdneo
Copy link
Member

jdneo commented Oct 10, 2019

@hologerry That's a good finding. Would you like to send out a PR? I can take a look at the globe icon based on your contribution.

@hologerry
Copy link
Contributor Author

OK, I will do it today.

@jdneo jdneo added the enhancement New feature or request label Oct 10, 2019
@hologerry hologerry mentioned this issue Oct 10, 2019
Merged
@hologerry hologerry changed the title Please update the icons with new outline style icons (provide by VS Code) Please update the icons with new outline style icons (provided by VS Code) Oct 10, 2019
@jdneo jdneo closed this as completed Oct 11, 2019
@jdneo jdneo modified the milestones: 0.15.7, 0.15.8 Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.15.8
Development

No branches or pull requests
2 participants
@jdneo @hologerry