{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":221479459,"defaultBranch":"master","name":"pytorch","ownerLogin":"jdonald","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2019-11-13T14:35:26.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1616866?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1690847380.0","currentOid":""},"activityList":{"items":[{"before":"f14b0318d7173f81cb07b80b9b70007d6ce9fb5b","after":"7655010e8df4814bf00715de77be10f2fcb3e6ba","ref":"refs/heads/export-D47736268","pushedAt":"2023-08-01T12:49:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jdonald","name":null,"path":"/jdonald","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1616866?s=80&v=4"},"commit":{"message":"[pytorch] Suppress C4624 warnings on Windows (#106348)\n\nSummary:\nPull Request resolved: https://github.com/pytorch/pytorch/pull/106348\n\nBuilding on Microsoft Visual Studio can show excessive warnings of the form:\n```\ncaffe2\\c10\\util\\Optional.h(212): warning C4624: 'c10::constexpr_storage_t<T>': destructor was implicitly defined as deleted\n        with\n        [\n            T=std::string\n        ]\ncaffe2\\c10\\util\\Optional.h(411): note: see reference to class template instantiation 'c10::constexpr_storage_t<T>' being compiled\n        with\n        [\n            T=std::string\n        ]\ncaffe2\\c10\\util\\Optional.h(549): note: see reference to class template instantiation 'c10::trivially_copyable_optimization_optional_base<T>' being compiled\n        with\n        [\n            T=std::string\n        ]\n```\n\nWhile we have macros such as `C10_CLANG_DIAGNOSTIC_{PUSH,POP,IGNORE}`, no there's no equivalent `C10_MSVC_DIAGNOSTIC_*`, so just do the suppressions explicitly.\n\nTest Plan: CI should complete, but Windows build log will no longer contain C4624 warnings\n\nDifferential Revision: D47736268\n\nfbshipit-source-id: 20bcf31039ca4751e2c2bd27799ebea83a1b8df3","shortMessageHtmlLink":"[pytorch] Suppress C4624 warnings on Windows (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1830226710\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/106348\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/106348/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/106348\">pytorch#106348</a>)"}},{"before":null,"after":"f14b0318d7173f81cb07b80b9b70007d6ce9fb5b","ref":"refs/heads/export-D47736268","pushedAt":"2023-07-31T23:49:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jdonald","name":null,"path":"/jdonald","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1616866?s=80&v=4"},"commit":{"message":"[pytorch] Suppress C4624 warnings on Windows\n\nSummary:\nBuilding on Microsoft Visual Studio can show excessive warnings of the form:\n```\ncaffe2\\c10\\util\\Optional.h(212): warning C4624: 'c10::constexpr_storage_t<T>': destructor was implicitly defined as deleted\n        with\n        [\n            T=std::string\n        ]\ncaffe2\\c10\\util\\Optional.h(411): note: see reference to class template instantiation 'c10::constexpr_storage_t<T>' being compiled\n        with\n        [\n            T=std::string\n        ]\ncaffe2\\c10\\util\\Optional.h(549): note: see reference to class template instantiation 'c10::trivially_copyable_optimization_optional_base<T>' being compiled\n        with\n        [\n            T=std::string\n        ]\n```\n\nWhile we have macros such as `C10_CLANG_DIAGNOSTIC_{PUSH,POP,IGNORE}`, no there's no equivalent `C10_MSVC_DIAGNOSTIC_*`, so just do the suppressions explicitly.\n\nTest Plan: CI should complete, but Windows build log will no longer contain C4624 warnings\n\nDifferential Revision: D47736268\n\nfbshipit-source-id: af25714a0136054fed8c0c6fb20b18ac5eb20ce5","shortMessageHtmlLink":"[pytorch] Suppress C4624 warnings on Windows"}},{"before":null,"after":"668f36948c1dbace44307bae8c532550801a9074","ref":"refs/heads/export-D47735319","pushedAt":"2023-07-25T14:03:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jdonald","name":null,"path":"/jdonald","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1616866?s=80&v=4"},"commit":{"message":"[pytorch] Fix MSVC unexpected tokens following preprocessor directive\n\nSummary:\nFix this warning:\n```\ncaffe2\\c10\\macros\\Macros.h(138): warning C4067: unexpected tokens following preprocessor directive - expected a newline\n```\n`caffe2/c10/util/variant.h` already has a similar to check and define a stub for `__has_attribute(x)`, so this would not be new to caffe2/pytorch.\n\nTest Plan: CI should complete, still with plenty of caffe2 warnings but this one should be gone from the Windows build log\n\nDifferential Revision: D47735319\n\nfbshipit-source-id: 4dc866ff2d9ae4bf1dcf50c33e5c3d37c574a8f0","shortMessageHtmlLink":"[pytorch] Fix MSVC unexpected tokens following preprocessor directive"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADYXsAaAA","startCursor":null,"endCursor":null}},"title":"Activity · jdonald/pytorch"}