Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mrml-core): script elements should remain with open and close element #320

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

jdrouet
Copy link
Owner

@jdrouet jdrouet commented Aug 10, 2023

Fixes #319

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #320 (c61f0e0) into main (840bb97) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head c61f0e0 differs from pull request most recent head e36bdeb. Consider uploading reports for the commit e36bdeb to get more accurate results

@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   93.12%   93.21%   +0.08%     
==========================================
  Files         230      230              
  Lines       12115    12136      +21     
==========================================
+ Hits        11282    11312      +30     
+ Misses        833      824       -9     
Files Changed Coverage Δ
packages/mrml-core/src/node/render.rs 89.28% <100.00%> (+6.42%) ⬆️

... and 2 files with indirect coverage changes

…ment

Signed-off-by: Jérémie Drouet <jeremie.drouet@datadoghq.com>
Signed-off-by: Jérémie Drouet <jeremie.drouet@datadoghq.com>
@jdrouet jdrouet enabled auto-merge (squash) August 10, 2023 16:14
@jdrouet jdrouet merged commit 192fadf into main Aug 10, 2023
5 checks passed
@jdrouet jdrouet deleted the issue-319 branch August 10, 2023 16:16
@github-actions github-actions bot mentioned this pull request Oct 7, 2023
@jdrouet jdrouet mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mj-raw incorrectly omits closing tag
1 participant