Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added --broadcast-whitelist option #39
I added a new --broadcast-whitelist option that in principle is just a copy of --whitelist but works on the broadcaster, i.e. only hosts from a given network can subscribe to its events. It just denies clients to connect, so another Comet session with the --remote flag set to that broadcaster will try to connect forever (although in increasing intervals). This is not ideal, but I don't see a nice way around it.
I also fixed a minor but in broker.py, where log.warning is used instead of log.warn.
Thank you for this! My initial thought is that the code looks good; I'll dive into it further as soon as I get chance.
Can you confirm what the copyright status of this code is? Are you willing and able to assign copyright to me, or do you/your employer need to be mentioned in the project's licensing statement?
referenced this pull request
Mar 15, 2016
Thank you! I'm reviewing this code today. Of course, I'm delighted to list you as a contributor. Currently, the only details I have for you are the name "thusser" and the e-mail address in your git commits. If you'd like me to add a full name, URL, etc, please send it my way.
I've already merged your bug fix to master and pushed it into a new release -- many thanks!
I like the broadcaster whitelisting feature. However, I think we can make it a bit simpler, because there's no real need to make a new factory class: we can just reuse the existing
Starting from your commit, I've made those changes and added some docs and tests. The result is on PR #41. Could you please take a look and check if you're happy with these changes? Thanks!