Add ability to register custom services to Authom #15

Merged
merged 2 commits into from Nov 8, 2012

Conversation

Projects
None yet
3 participants
Contributor

ovaillancourt commented Jul 6, 2012

This pull adds the registerService method that allows someone to register an authom-compatible service that is too specific to go into the core services folder. (For example a business-specific login/pass system.)

This also allows to override the behavior of existing "core" services.

Also added documentation + usage example.

ovaillancourt added some commits Jun 20, 2012

@ovaillancourt ovaillancourt Added a "registerService" method to authom. Makes it possible to add …
…services without having to place them into the /lib folder inside the authom module. Useful for local business-domain auth services that wouldn't be suited for a pull in authom's core. (For example a company specific in-house login/password system.)
131eeea
@ovaillancourt ovaillancourt Small programming style tweaks. c3277c5
Contributor

deedubs commented Jul 18, 2012

+1 to this. Seems like a more efficient way to allow people to add services. I would almost like to see all the 'services' registered in this way.

Contributor

deedubs commented Nov 7, 2012

@jed Is there something we can do to improve this PR to get it accepted? Or are you against the idea outright?

@jed jed added a commit that referenced this pull request Nov 8, 2012

@jed jed Merge pull request #15 from ovaillancourt/customservice
Add ability to register custom services to Authom
584ea91

@jed jed merged commit 584ea91 into jed:master Nov 8, 2012

Owner

jed commented Nov 8, 2012

it's a good idea, just fell through the cracks. merged, about to update npm.

Contributor

deedubs commented Nov 8, 2012

Thanks Jed!

Sent from my iPhone

On 2012-11-07, at 10:00 PM, Jed Schmidt notifications@github.com wrote:

it's a good idea, just fell through the cracks. merged, about to update npm.


Reply to this email directly or view it on
GitHubhttps://github.com/jed/authom/pull/15#issuecomment-10174199.

Owner

jed commented Nov 8, 2012

don't thank me, thank @ovaillancourt!

Contributor

ovaillancourt commented Nov 8, 2012

haha, well thanks jed anyways! Man I had completely forgot about that pull too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment