Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow authom users to specify fields for facebook #38

Merged
merged 3 commits into from Mar 13, 2013

Conversation

Projects
None yet
3 participants
Contributor

pspeter3 commented Mar 2, 2013

This means that people can request picture or some other non standard fields.

hanging if statements like this are a bit dangerous... would you mind adding the brackets?

@pspeter3 pspeter3 Adding brackets
I wasn't sure what the coding style was. Sorry about that
2c8fb4e
Contributor

pspeter3 commented Mar 3, 2013

Updated to add the brackets

Owner

jed commented Mar 4, 2013

would you mind adding a description to the README as well?

@pspeter3 pspeter3 Updating the README for Facebook
Demonstrate how to use the new fields option for the facebook driver.
605ed0b
Contributor

pspeter3 commented Mar 12, 2013

Hey @jed do I need to anything else to get a ship it :shipit:?

@jed jed added a commit that referenced this pull request Mar 13, 2013

@jed jed Merge pull request #38 from pspeter3/master
Allow authom users to specify fields for facebook
381073d

@jed jed merged commit 381073d into jed:master Mar 13, 2013

Owner

jed commented Mar 13, 2013

nope! thanks, @pspeter3!

"this.fields" will always evaluate to "undefined" (the string).

Owner

jed replied Mar 26, 2013

@pspeter3, can you confirm?

Contributor

pspeter3 commented on 6fd282e Mar 28, 2013

Based on my testing, supplying the fields param works. I get this response back from Facebook (changing the id and token for privacy)

{
  "token": "foo",
  "id": "bar",
  "data": {
    "name": "Phips Peter",
    "id": "bar",
    "picture": {
      "data": {
        "url": "https://fbcdn-profile-a.akamaihd.net/hprofile-ak-snc6/pic.jpg",
        "is_silhouette": false
      }
    }
  },
  "service": "facebook"
}

Without the fields parameter supplied

{
  "token": "foo",
  "id": "bar",
  "data": {
    "id": "bar",
    "name": "Phips Peter",
    "first_name": "Phips",
    "last_name": "Peter",
    "link": "link",
    "username": "username",
    "gender": "male",
    "timezone": -7,
    "locale": "en_US",
    "verified": true,
    "updated_time": "2013-03-27T04:42:06+0000"
  },
  "service": "facebook"
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment