Fix #41 - custom Facebook fields are not correctly appended to the oauth request url. #42

Merged
merged 1 commit into from Mar 27, 2013

Conversation

Projects
None yet
2 participants
Contributor

ovaillancourt commented Mar 26, 2013

"this.fields" on line 44 of the facebook service always evaluate to "undefined", which would prompt facebook to poke into the page /meundefined instead of the proper /me?fields=[bla] url. (Would've also had hard-coded a query-string in the path on which a second one generated in oauth2.js would've been appended, which would've been problematic too.)

The following pull resolves the issue without removing the capability of adding custom fields by using the "this.user.query" object which was created for this purpose in the first place.

jed added a commit that referenced this pull request Mar 27, 2013

Merge pull request #42 from ovaillancourt/patch-2
Fix #41 - custom Facebook fields are not correctly appended to the oauth request url.

@jed jed merged commit a74fbe9 into jed:master Mar 27, 2013

Owner

jed commented Mar 27, 2013

thanks, @ovaillancourt! pushed to npm as well.

Contributor

ovaillancourt commented Mar 27, 2013

thanks!

@ovaillancourt ovaillancourt deleted the ovaillancourt:patch-2 branch Mar 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment