Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update function for generation a new unique id #225

Closed
wants to merge 1 commit into from
Closed

Update function for generation a new unique id #225

wants to merge 1 commit into from

Conversation

dunin
Copy link

@dunin dunin commented Oct 7, 2018 •
edited

Hi.

Argument prefix is not using in unuqueId(prefix) function.

Also, when prefix is undefined — check of prefix === null is not passed because it is undefined. 🙃

@jedfoster jedfoster mentioned this pull request Feb 22, 2019
Open
26 tasks
jedfoster added a commit that referenced this pull request Feb 22, 2019
@jedfoster
Remove unused prefix arg from uniqueId
97eb9c9 
Closes #225
@jedfoster
Copy link
Owner

This was a good catch. Thank you.

@jedfoster jedfoster closed this Feb 22, 2019
@piddubnij piddubnij mentioned this pull request Aug 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dunin @jedfoster