remove bundler/setup from cli.rb #5

Merged
merged 1 commit into from Aug 13, 2012

Conversation

Projects
None yet
2 participants
Contributor

erikh commented Aug 10, 2012

Hey Patrick,

I've got another fix for you. If you run logstash-cli anywhere that has a Gemfile, requires break if they don't exist in that gemfile, e.g. for a rails app that doesn't have amqp in the Gemfile.

The solution here is to remove the 'bundler/setup' require which then relies on rubygems to do the resolution, which is the ideal for gem-based installations. This shouldn't break 'bundle exec logstash-cli' for development, but please let me know if it does and I will send you more patches.

If you find this patch satisfactory, and don't mind cutting another release, I would really appreciate it.

@jedi4ever jedi4ever added a commit that referenced this pull request Aug 13, 2012

@jedi4ever jedi4ever Merge pull request #5 from Tout/bundler_fix
remove bundler/setup from cli.rb
a35ce5f

@jedi4ever jedi4ever merged commit a35ce5f into jedi4ever:master Aug 13, 2012

Owner

jedi4ever commented Aug 13, 2012

done! thanks a bunch.

On 10/08/12 19:13, Erik Hollensbe wrote:

Hey Patrick,

I've got another fix for you. If you run logstash-cli anywhere that
has a Gemfile, requires break if they don't exist in that gemfile,
e.g. for a rails app that doesn't have |amqp| in the Gemfile.

The solution here is to remove the 'bundler/setup' require which then
relies on rubygems to do the resolution, which is the ideal for
gem-based installations. This shouldn't break 'bundle exec
logstash-cli' for development, but please let me know if it does and I
will send you more patches.

If you find this patch satisfactory, and don't mind cutting another
release, I would really appreciate it.


    You can merge this Pull Request by running:

git pull https://github.com/Tout/logstash-cli bundler_fix

Or view, comment on, or merge it at:

#5

    Commit Summary


Reply to this email directly or view it on GitHub
#5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment