Feature/windows #273

Merged
merged 5 commits into from Nov 5, 2012

Projects

None yet

3 participants

@jedi4ever
Owner

catch me on the #veewee or #vagrant channel.

@Keno
Keno commented Jun 27, 2012

What does it take to get this working completely?

@hh
hh commented Oct 29, 2012

Can I get some feedback on this?

@jedi4ever
Owner

Hey @hh , give me another week to give more detailed feedback, but it looks awesome!

browsed quickly through it , only thing that looked 'weird' was the knife winrm command in veewee code? What are you using it for?

@hh
hh commented Nov 2, 2012

I think it's not actually executed, but is just part of a string output.
The ssh version shows how to connect via ssh, I was showing the only tool I
know how to use cross-platform connect to a windows box via winrm protocol.

It might be interesting to write a winrm command line tool, but the only
one I was aware of was knife winrm, though I admit I probably didn't look
very hard. 8)

hh.github.com has pointer a repo that utilizes much of these changes.

@jedi4ever
Owner

can we move the em-winrm from the gemspec to an official gem? Or do you require your fork for this?

@jedi4ever
Owner

do we need a windows/winrm only feature?

Can't we use the existing one that figures out to use winrm/ssh based on the definition?
You could use @windows and @linux to filter tests

@jedi4ever
Owner

Also is there a reason why you added ruby-libvirt to the gems? I understand that it was added to the test group but

This will brake the installation in case you don't have it installed when you do the simple 'bundle install' . I found no way to exclude a group from bundle install by default.

@jedi4ever
Owner

maybe we can move the check definition.winrm_user && definition.winrm_password to definition itself, instead of repeating it everytime ?

@jedi4ever
Owner

Would also be nice you could 'adapt' the other virtualization providers for winrm, now that the change is still fresh in your mind. Thanks!

@jedi4ever jedi4ever merged commit 8ce8f06 into jedi4ever:master Nov 5, 2012
@jedi4ever
Owner

@hh merged but removed the gemspec thing and implemented interactive winrm (simple REPL style).

See - http://www.ruby-doc.org/gems/docs/k/knife-windows-0.5.8/Chef/Knife/Winrm.html#method-i-interactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment