Do not throw runtime exception on SSH command on bad exit code #306

Merged
merged 2 commits into from May 14, 2012

2 participants

@gposton

I ran into an error when running box validations where a non-zero exit code was produced. I received a stack trace on the SSH command step (And I run "mount|grep veewee-validation" over ssh).

I would expect the runtime exception not to have been raised and the subsequent validation step (I should see veewee-validation) to catch the error (which provides more descriptive and valuable insight into the actual issue).

Ideally the cucumber code should do any needed validation (check output,exit codes, etc), thus runtime exceptions should not be thrown in the event of a bad exit code during tests.

@jedi4ever jedi4ever merged commit fefa4e1 into jedi4ever:master May 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment