Merge options from Veeweefile #342

Closed
wants to merge 4 commits into
from

Projects

None yet

1 participant

@mconigliaro

We discovered evidence that it should be possible to configure Veewee via a "Veeweefile," but since we couldn't find any documentation on this particular feature (nor could we get it to work "out of the box"), we basically had to reverse-engineer it.

The Veeweefile appears to expect a format like this:

Veewee::Config.run do |config|
  config.veewee.<option> = <value>
end

Although the file above will get parsed without errors, we could not get Veewee to honor any of the options set within the Veeweefile. Veewee::Environment#initialize does not seem to read the Veeweefile on its own. Interestingly the call to env.load! in https://github.com/jedi4ever/veewee/blob/master/bin/veewee#L15 gives us what we want, but https://github.com/jedi4ever/veewee/blob/master/lib/veewee/command/virtualbox.rb#L14-18 (for example) is missing the crucial call to venv.load!, which means you will just end up with the default options every time.

Rather than adding venv.load! all over the place, I decided to patch Veewee::Environment#initialize so that the Veeweefile options get merged in right from the beginning. I hope this was the right thing to do...

@mconigliaro

Closing this so I can resubmit it from the fork under the LivingSocial organization.

@mconigliaro

New pull request is here: #344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment