Skip to content

Merge options from Veeweefile #344

Merged
merged 1 commit into from Aug 3, 2012

2 participants

@mconigliaro

We discovered evidence that it should be possible to configure Veewee via a "Veeweefile," but since we couldn't find any documentation on this particular feature (nor could we get it to work "out of the box"), we basically had to reverse-engineer it.

The Veeweefile appears to expect a format like this:

Veewee::Config.run do |config|
  config.veewee.<option> = <value>
end

Although the file above will get parsed without errors, we could not get Veewee to honor any of the options set within the Veeweefile. Veewee::Environment#initialize does not seem to read the Veeweefile on its own. Interestingly the call to env.load! in https://github.com/jedi4ever/veewee/blob/master/bin/veewee#L15 gives us what we want, but https://github.com/jedi4ever/veewee/blob/master/lib/veewee/command/virtualbox.rb#L14-18 (for example) is missing the crucial call to venv.load!, which means you will just end up with the default options every time.

Rather than adding venv.load! all over the place, I decided to patch Veewee::Environment#initialize so that the Veeweefile options get merged in right from the beginning. I hope this was the right thing to do...

@jedi4ever jedi4ever merged commit 80db13f into jedi4ever:master Aug 3, 2012
@jedi4ever
Owner

It was part of a trial, but I think there's value in pursuing the Veeweefile support anyway.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.