Make IP retrieval more reliable #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this commit, the public IP returned from ruby-libvirt may not be an array. The code assumes it's an array and always grabs the first item. I'm not sure if it's ever an array, but to be safe this commit ensures what's returned from #public_ip_address is an array, then the first item is selected.
jedi4ever
added a commit
that referenced
this pull request
Aug 29, 2012
Make IP retrieval more reliable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this commit, the public IP returned from ruby-libvirt may
not be an array. The code assumes it's an array and always grabs the
first item. I'm not sure if it's ever an array, but to be safe this
commit ensures what's returned from #public_ip_address is an array, then
the first item is selected.