Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ruby / Rubygems-Version in postinstall.sh for Ubuntu more DRY #42

Closed
wants to merge 2 commits into from
Closed

Make Ruby / Rubygems-Version in postinstall.sh for Ubuntu more DRY #42

wants to merge 2 commits into from

Conversation

ctrabold
Copy link
Collaborator

Hi Patrick,

I introduced two new shell for the Ruby / Rubygems-Version which speeds up the process of these two (=Timesaver).

Tested by calling "postinstall.sh" directly - worked as expected, no errors.

Cheers

Christian

@hedgehog
Copy link
Contributor

hedgehog commented Jul 7, 2011

@ctrabold, I'm not sure this is the env variable needed going forward. If you review the postinstall.sh in this pull request
you'll see that what is needed is more finegrained. Also I think VEEWEE_* in this case is too specific and we should use more generic names. the reason for this is I think the way to structure the scripts is to replace postinstall.sh with
veewee_pre.sh, generic.sh, veewee_post.sh. That is, the veewee definition file 'definition.rb` should contain:

  <snip>
 :postinstall_files    => [ 'veewee_pre.sh', 'generic.sh', 'veewee_post.sh' ],

Your thoughts?

@ctrabold
Copy link
Collaborator Author

Good point. After reading your pull request, I totally agree.

My point in introducing the env variables was simple to make changing the versions of ruby / rubygems more fun ;)

I'll close this pull request.

@ctrabold ctrabold closed this Jul 26, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants