allow definition name to contain plus #441

Merged
merged 3 commits into from Dec 12, 2012

Projects

None yet

2 participants

@mpapis
Collaborator
mpapis commented Dec 9, 2012

here is the log with only the first part of the fix:

$ VEEWEE_LOG=STDOUT veewee vbox build openSUSE-12.2-DVD+NET-x86_64
2012-12-09 20:34:00 +0100 -  - [veewee] Command: "VBoxManage list runningvms"
2012-12-09 20:34:00 +0100 -  - [veewee] Output:
2012-12-09 20:34:00 +0100 -  - [veewee] -------
2012-12-09 20:34:00 +0100 -  - [veewee] "openSUSE-12.2-DVD+NET-x86_64" {1dc38e51-1959-4a52-9e63-f40979db6e7e}
2012-12-09 20:34:00 +0100 -  - [veewee] Vm running? false
2012-12-09 20:34:00 +0100 - ui - [veewee] Box is not running
Box is not running
@jedi4ever
Owner

@mpapis thanks. Wondering what the correct way is here. It currently does a regexp, maybe it makes more sense to use the Regexp.escape function instead of the gsub?

What do you think? Be great if you can submit a new patch for this approach.

@mpapis
Collaborator
mpapis commented Dec 12, 2012

it looks a lot better now! thanks for the suggestion.

@jedi4ever jedi4ever merged commit dcb4e7a into jedi4ever:master Dec 12, 2012
@jedi4ever
Owner

thx @mpapis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment