Modify Environment to pass Options hash to Providers #448

Merged
merged 2 commits into from Dec 13, 2012

Projects

None yet

2 participants

@jasonberanek

Veewee::Provider::Core supports receiving the command line options passed into the Command, but the object was not provided during the Provider class lifecycle. This pull requests inserts an additional initialization parameter to the Veewee::Providers class to allow it to initialize an individual Provider with the command line options, as well as modifying the Veewee::Environment class to provide this object to the initialize method.

Note, this change should have no effect on existing providers, as the previous version of Veewee::Providers provided an empty object for the options initialization variable for Veewee::Provider::Core. These values are important for more involved providers that cannot make assumptions about a local file system (e.g., an external hypervisor).

@jasonberanek

Updated the Veewee::Providers to make sure options gets initialized, also cleaned up the intention of that file while I was in there.

@jedi4ever
Owner

thanks @jasonberanek !

@jedi4ever jedi4ever merged commit b862f35 into jedi4ever:master Dec 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment