KVM provider: restructured to always use Fog.io to connect to libvirt #472

merged 4 commits into from Jan 9, 2013


None yet
2 participants

ffeldhaus commented Jan 9, 2013

As discussed in pull request #465, I restructured the KVM provider to always use Fog.io instead of a direct connection to libvirt. This allows to configure the libvirt parameters in the fog.io config file and should fix issue #470.

I also extended the documentation for KVM with some more details on prerequisites and usage of the KVM provider.

I successfully tested this pull request, but would welcome feedback by others if it is working fine.

ffeldhaus added some commits Jan 9, 2013

@ffeldhaus ffeldhaus KVM Provider
- removed check for available gems. Requiring fog is sufficient to get meaningful error messages if either the fog or libvirt gems are not present
- set libvirt_uri and libvirt_ip_command parameters for the Fog libvirt provider if they are not already set in the fog config file
- use the fog libvirt provider instead of a libvirt directly to make use of the configuration settings in .fog
- the availability of at least one storage pool and network is now checked through fog methods
- the libvirt version is now checked through the fog method
- the connection to libvirt is not closed as it gets automatically closed when the garbage collector deletes the variable
@ffeldhaus ffeldhaus KVM Box
- removed requiring of libvirt and fog gems as this is now handled in the KVM provider class
- removed the options for creating the libvirt connection as these are now handled in the KVM provider class
@ffeldhaus ffeldhaus KVM validate
- removed vbox tag and added kvm tag
@ffeldhaus ffeldhaus KVM documentation
- extended the documentation with more details on prerequisites and usage of the kvm provider

jedi4ever commented Jan 9, 2013

THis is GREAT work @ffeldhaus - muchos gracias!

jedi4ever merged commit 00e828f into jedi4ever:master Jan 9, 2013

ffeldhaus deleted the ffeldhaus:kvm-provider branch Jan 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment