Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress: add pin message #231

Merged
merged 2 commits into from Oct 2, 2022
Merged

progress: add pin message #231

merged 2 commits into from Oct 2, 2022

Conversation

iyear
Copy link
Contributor

@iyear iyear commented Oct 2, 2022

Proposed Changes

Add pin message for progress bar, It will be displayed at the top of all active trackers.

Developers can display some dynamic information here (e.g. CPU, load, memory)

@coveralls
Copy link

coveralls commented Oct 2, 2022

Pull Request Test Coverage Report for Build 3168573360

  • 27 of 27 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 99.78%

Totals Coverage Status
Change from base Build 3120356346: 0.002%
Covered Lines: 3168
Relevant Lines: 3175

💛 - Coveralls

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jedib0t
Copy link
Owner

jedib0t commented Oct 2, 2022

I like this feature and I see how this can be useful, but I think the interfaces can be finessed a bit more. I'll accept this change and deliver one more change on top to change the interfaces/keyboard a bit.

@jedib0t jedib0t merged commit 99ac11f into jedib0t:main Oct 2, 2022
@jedib0t
Copy link
Owner

jedib0t commented Oct 2, 2022

@iyear I've published a new release with support for Pinned messages that you contributed. Made some changes on top, but it contains the essence of what you designed: https://github.com/jedib0t/go-pretty/releases/tag/v6.4.0

@iyear
Copy link
Contributor Author

iyear commented Oct 3, 2022

@jedib0t More beautiful and elegant, thank you!

Please forgive my poor English XD.

@iyear iyear deleted the feat-progress-pin branch October 3, 2022 02:51
@jedib0t
Copy link
Owner

jedib0t commented Oct 5, 2022

@jedib0t More beautiful and elegant, thank you!

Please forgive my poor English XD.

Hey your English is fine. I really appreciate the contribution! 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants