Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress: fix overall tracker disappears in corner case #246

merged 1 commit into from Nov 28, 2022


Copy link

@iyear iyear commented Nov 27, 2022

Proposed Changes

Fixes #245

Copy link

coveralls commented Nov 27, 2022

Pull Request Test Coverage Report for Build 3558760113

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 3415419885: 0.0%
Covered Lines: 3250
Relevant Lines: 3250

💛 - Coveralls

Copy link

sonarcloud bot commented Nov 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor Author

iyear commented Nov 27, 2022

Test added

Copy link

@jedib0t jedib0t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@jedib0t jedib0t merged commit 72834de into jedib0t:main Nov 28, 2022
4 checks passed
Copy link

jedib0t commented Nov 28, 2022

This fix is now in tag:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

[progress] corner case: overall tracker disappears
3 participants