Use VersionAdmin.revision_manager rather than default_revision_manager #7

Merged
merged 4 commits into from Jun 20, 2012

Conversation

Projects
None yet
2 participants
@mlavin
Contributor

mlavin commented Jun 12, 2012

This change is to support using a non-default revision_manager on the CompareVersionAdmin. This is already support by the base VersionAdmin. Still needs some tests which I'm happy to write. Just wanted to get the discussion started to see if this seemed like a reasonable approach.

@jedie

This comment has been minimized.

Show comment
Hide comment
@jedie

jedie Jun 12, 2012

Owner

I use only the default revision_manager, so i didn't need this, yet. But if it work and the unittests didn't fail i would merge this.

Owner

jedie commented Jun 12, 2012

I use only the default revision_manager, so i didn't need this, yet. But if it work and the unittests didn't fail i would merge this.

@mlavin

This comment has been minimized.

Show comment
Hide comment
@mlavin

mlavin Jun 19, 2012

Contributor

Rebased to the latest master and added tests.

Contributor

mlavin commented Jun 19, 2012

Rebased to the latest master and added tests.

jedie added a commit that referenced this pull request Jun 20, 2012

Merge pull request #7 from mlavin/configure-reversion-manager
Use VersionAdmin.revision_manager rather than default_revision_manager
contributed by mlavin, thanks!

@jedie jedie merged commit af0b807 into jedie:master Jun 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment