Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zig build for windows platform issue #1371

Closed
meiyese opened this issue May 23, 2024 · 1 comment
Closed

Zig build for windows platform issue #1371

meiyese opened this issue May 23, 2024 · 1 comment

Comments

@meiyese
Copy link

meiyese commented May 23, 2024

Hi, I use zig build for windows, and found that the dll with cause crash.

but msvc build is ok. It may caused by HAVE_AMD64_ASM macro.

HAVE_AMD64_ASM is on by default for zig build, which is off for msvc.
jedisct1 added a commit that referenced this issue May 23, 2024
@jedisct1
Undefine HAVE_{AMD64,AVX}_ASM with the Windows calling convention
e9cc216 
Fixes #1371
@jedisct1
Copy link
Owner

Good catch, thank you!

Yes, absolutely, the calling conventions are different on Windows.

This should be fixed now. Thanks again!

Repository owner locked and limited conversation to collaborators Aug 21, 2024
ghazel pushed a commit to clostra/libsodium that referenced this issue Sep 7, 2024
@jedisct1 @ghazel
Undefine HAVE_{AMD64,AVX}_ASM with the Windows calling convention
c6933e8 
Fixes jedisct1#1371
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jedisct1 @meiyese