Skip to content

Commit bf6fcd4

Browse files
committed
pure_strcmp(): len(s2) can be > len(s1)
Reported by Antonio Morales from GitHub Security Labs, thanks!
1 parent 9a8d379 commit bf6fcd4

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

Diff for: src/utils.c

+5-1
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,9 @@ int pure_memcmp(const void * const b1_, const void * const b2_, size_t len)
4545

4646
int pure_strcmp(const char * const s1, const char * const s2)
4747
{
48-
return pure_memcmp(s1, s2, strlen(s1) + 1U);
48+
const size_t s1_len = strlen(s1);
49+
const size_t s2_len = strlen(s2);
50+
const size_t len = (s1_len < s2_len) ? s1_len : s2_len;
51+
52+
return pure_memcmp(s1, s2, len + 1);
4953
}

0 commit comments

Comments
 (0)