Skip to content

Commit

Permalink
PostgreSQL: don't escape the port number in the connection string
Browse files Browse the repository at this point in the history
It's already an integer, not a string.

Reported by Artyom Davidov, thanks!
  • Loading branch information
jedisct1 committed Jan 20, 2022
1 parent a8947d6 commit c3f0f3c
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/log_pgsql.c
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,6 @@ static int pw_pgsql_connect(PGconn ** const id_sql_server)
*id_sql_server = NULL;

if ((escaped_server = pw_pgsql_escape_conninfo(server)) == NULL ||
(escaped_port = pw_pgsql_escape_conninfo(port)) == NULL ||
(escaped_db = pw_pgsql_escape_conninfo(db)) == NULL ||
(escaped_user = pw_pgsql_escape_conninfo(user)) == NULL ||
(escaped_pw = pw_pgsql_escape_conninfo(pw)) == NULL) {
Expand All @@ -296,7 +295,7 @@ static int pw_pgsql_connect(PGconn ** const id_sql_server)
}
if (SNCHECK(snprintf(conninfo, sizeof_conninfo,
PGSQL_CONNECT_FMTSTRING,
escaped_server, escaped_port, escaped_db,
escaped_server, port, escaped_db,
escaped_user, escaped_pw), sizeof_conninfo)) {
goto bye;
}
Expand All @@ -314,7 +313,6 @@ static int pw_pgsql_connect(PGconn ** const id_sql_server)
bye:
free(conninfo);
free(escaped_server);
free(escaped_port);
free(escaped_db);
free(escaped_user);
free(escaped_pw);
Expand Down

0 comments on commit c3f0f3c

Please sign in to comment.