Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`grey` text color is invisible when using Solarized theme in terminal #29

Closed
mathiasbynens opened this Issue Jun 10, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@mathiasbynens
Copy link
Contributor

mathiasbynens commented Jun 10, 2014

The grey text color used by this task is invisible when using the Solarized Dark terminal theme. To read the text, you have to select it :( Given how popular Solarized is, can we use a different color than grey?

Screenshot:

@jedrichards

This comment has been minimized.

Copy link
Owner

jedrichards commented Jun 10, 2014

That seems like a very reasonable request. Perhaps just have it output in the default text colour instead? I'm not overly attached to the grey.

@mathiasbynens

This comment has been minimized.

Copy link
Contributor Author

mathiasbynens commented Jun 10, 2014

Default would be perfect IMHO. I’ll submit a PR.

mathiasbynens added a commit to mathiasbynens/grunt-rsync that referenced this issue Jun 10, 2014

@jedrichards

This comment has been minimized.

Copy link
Owner

jedrichards commented Jun 10, 2014

Ty very much! Just published 0.6.1 to npm with this change in it.

@mathiasbynens

This comment has been minimized.

Copy link
Contributor Author

mathiasbynens commented Jun 10, 2014

Thanks for taking care of this so quickly! ♥ We use grunt-rsync for Dev.Opera (repo) btw.

@jedrichards

This comment has been minimized.

Copy link
Owner

jedrichards commented Jun 10, 2014

Awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.