Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start the work on adding support for TB 78+ #99

Closed
jeevatkm opened this issue Apr 29, 2020 · 16 comments
Closed

Start the work on adding support for TB 78+ #99

jeevatkm opened this issue Apr 29, 2020 · 16 comments

Comments

@jeevatkm
Copy link
Owner

It seems TB has pushing add-on on to next level challenge - Migrating to WebExtension otherwise, it won't work.

Screen Shot 2020-04-29 at 1 44 59 AM

🤔 First I have to start learning WebExtension so that I can migrate 😆

@jeevatkm jeevatkm changed the title Start the work adding support for TB 76+ Start the work on adding support for TB 76+ Apr 29, 2020
@jeevatkm jeevatkm pinned this issue Apr 29, 2020
@jeevatkm jeevatkm added this to the v3.0.0 Release milestone Apr 29, 2020
@jeevatkm jeevatkm changed the title Start the work on adding support for TB 76+ Start the work on adding support for TB 78+ May 10, 2020
@jeevatkm
Copy link
Owner Author

jeevatkm commented Sep 5, 2020

As I looking into it, turns out this is a complex task and requires a rewrite of the add-on. Not sure how much time it's going to take.

@jeevatkm
Copy link
Owner Author

Thought to mention it here for RWH users.

As it turns out, brand new RWH MailExtension development (complete rewrite is required for TB 78+) is happening on branch tb-78-mail-extension

@jeevatkm
Copy link
Owner Author

jeevatkm commented Sep 29, 2020

RWH MailExtension development is in-progress.

Technically it's happening in two parts -

  • One for the short term - just make it work with workarounds in TB 78
  • Another one for the long term - a complete rewrite from scratch to support TB 78+ roadmap. This part is very time consuming and lots of effort involved. - No ETA
    • Good thing, I will bring new features and improvements using the latest TB capabilities 😉

I appreciate your patience, thanks.


I'm hoping I will have a beta version for TB 78 in the upcoming week.

@jeevatkm
Copy link
Owner Author

jeevatkm commented Oct 5, 2020

Dear RWH User -

I have prepared the RHW v2.3.0-beta for try out.
Download Link: https://bit.ly/2F0cQNg
Sha256: 882b3abca3dde68413084d9680351dcee0b44d4c64cef4184e486abd3da30b11

Can you please test and share your feedback/confirmation?

PS: This short-term goal is to make RWH work in TB 78 after that I will start work brand new RWH v3.0.0 Mail extension.

@BackSpace54
Copy link

Hi Jeevatkm,
i will try RWH beta tonight (in a couple of hours - here UTC/GMT +2).
Feedback coming soon ;-)

@tidebre67
Copy link

Hey Jeeva, tks for beta version. Testing was positive. Could not see any problem in this test. Seems to work as in previous TB versions.

@m-i-k-e-y
Copy link

@jeevatkm

Thanks for the beta version. It is working, although the headers are hard to read when the dark theme is used.

@chdh
Copy link

chdh commented Oct 5, 2020

@jeevatkm Thank you very much. I was waiting for this. It works fine for me with TB 78.3.1.

@BackSpace54
Copy link

BackSpace54 commented Oct 5, 2020

Works like a charm except for "Reply list": no headers remplacement.
Don't remember if it works with v2.2.1

@jeevatkm
Copy link
Owner Author

jeevatkm commented Oct 6, 2020

@BackSpace54, @tidebre67, @m-i-k-e-y, @chdh - Thanks for the testing and confirmation.

@BackSpace54 - RWH add-on only supports Reply, Reply to All, and Forward.

@m-i-k-e-y - I have not learned the new TB theme concepts yet. The RWH v2.3.0 is just to make it work in TB 78. I will have to figure out the theme when working on RWH v3.0.0 Mail Extension.


I have received positive feedbacks here as well as on Disqus threads on the RWH page. I will start preparing for submitting RWH v2.3.0 to ATN.

@jeevatkm
Copy link
Owner Author

jeevatkm commented Oct 6, 2020

Just now, I have submitted RWH v2.3.0 to ATN for review.

@weksupport
Copy link

weksupport commented Oct 6, 2020 via email

@jeevatkm
Copy link
Owner Author

jeevatkm commented Oct 7, 2020

@weksupport Thanks for testing and confirmation.

@jeevatkm
Copy link
Owner Author

jeevatkm commented Oct 7, 2020

RWH v2.3.0 has been released to ATN and the new development will be tracked under #103.

@jeevatkm jeevatkm closed this as completed Oct 7, 2020
@jeevatkm jeevatkm unpinned this issue Oct 7, 2020
@spodermenpls
Copy link

spodermenpls commented Oct 7, 2020

@jeevatkm Is it to be expected that I can't access the "RWH preferences" with the new 2.3.0 build? The add-on does work now (thank you for your efforts!), but is using the English instead of the German locale for the headers, that I'd prefer. I see that there's a commit called "... preferences page started working", but I only can access RWH's "Details" and "Permissions" in the add-on panel.

Edit: Nevermind, I've found it. It wasn't self-explanatory though, I didn't expect it to be located in an extra "Add-on settings" menu in the Misc/Extras section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants