Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlight class #46

Merged
merged 2 commits into from Feb 14, 2012
Merged

Add highlight class #46

merged 2 commits into from Feb 14, 2012

Conversation

m-c
Copy link
Contributor

@m-c m-c commented Feb 8, 2012

Add class for highlight element instead of add css rule (z-index). It`s must be more flexible.
Add check in method guiders.hideAll (if current element highlight then dehighlight it).
Sorry for my english.

@jeff-oldgithub
Copy link

Great, thanks. I'll check on it when I periodically review Guider.js.

On Wed, Feb 8, 2012 at 2:40 AM, Maxim Troyanov <
reply@reply.github.com

wrote:

Hi.
I add class for highlight element instead of add css rule (z-index). It`s
must be more flexible.
And i add check in method guiders.hideAll (if current element highlight
then dehighlight it).
Sorry for my english.

You can merge this Pull Request by running:

git pull https://github.com/m-c/Guiders-JS master

Or you can view, comment on it, or merge it online at:

#46

-- Commit Summary --

  • Add class for highlight element instead of add css rule (z-index). It`s
    must be more flexible.
  • Add highlight class.

-- File Changes --

M guiders-1.2.0.css (5)
M guiders-1.2.0.js (9)

-- Patch Links --

https://github.com/jeff-optimizely/Guiders-JS/pull/46.patch
https://github.com/jeff-optimizely/Guiders-JS/pull/46.diff


Reply to this email directly or view it on GitHub:
#46

@jeff-oldgithub
Copy link

Yes, I agree, this is more flexible. Thanks - I'm merging now.

jeff-oldgithub pushed a commit that referenced this pull request Feb 14, 2012
Add highlight class
@jeff-oldgithub jeff-oldgithub merged commit ce4128f into pickhardt:master Feb 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants