Skip to content

Bugfixes #70

merged 2 commits into from Jun 26, 2012

3 participants


2 bugfixes, one for adjusting the "top" position correctly with body margin, the other for fixing a condition where _attach is called with "undefined" instead of "null", causing an exception

dbellizzi added some commits Jun 15, 2012
@dbellizzi dbellizzi fix exception in _attach when no current guider
If resize fires before the current guider is fully shown myGuider is
"undefined" which doesn't match null
@dbellizzi dbellizzi fix offset adjustment for top margin
top wasn't adjusted and base was NaN after this, though it wasn't used

@dbellizzi, thanks for the fix. The 'no guider current' was really annoying. Will be waiting for your patch in the new version.

@jeff-optimizely jeff-optimizely merged commit 4d947fb into jeff-optimizely:master Jun 26, 2012


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.