Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bower Support #78

Closed
wants to merge 1 commit into from
Closed

Bower Support #78

wants to merge 1 commit into from

Conversation

rajkissu
Copy link

  • Starts tag at 1.3.0 (semver)
  • Adds component.json for Bower integration
  • Adds git ignore list

@rajkissu
Bower Support
33bf1b4 
* Starts tag at 1.3.0 (semver)
* Adds component.json for Bower integration
* Adds git ignore list
@pickhardt
Copy link
Owner

Thanks @rajkissu. I am making major improvements to Guiders.js, that I'm calling version 2.0.0. This will be in it. Also, I can't merge this into master but will include it in dev. (dev is a new branch I added so that I can safely pull changes in) Closing this because I am including it in dev for version 2.0.0

@pickhardt pickhardt closed this Jan 27, 2013
spmason pushed a commit to spmason/Guiders-JS that referenced this pull request Dec 4, 2013
@pickhardt
First commit of the dev branch and beginning of version 2.0.0! Change…
1b8bb32 
…log:

- Started keeping a changelog in changelog.txt.
- Since this is a major change, I am incrementing the version number to 2.0.0. (Following Semantic Versioning, http://semver.org/)
- Created a dev branch on GitHub. (https://github.com/jeff-optimizely/Guiders-JS/tree/dev) Contributors, issue pull requests to the dev branch so I can safely pull them without worrying about screwing up master code.
- Changed the file names from guiders-(version).js and guiders-(version).css to simply guiders.js and guiders.css, so that it's easier to track changes in GitHub. If you want to know what version you have, just open the file or check guiders.version.
- Upgraded jQuery from 1.51 to 1.90. It should still work with older versions of jQuery.
- Use var guiders = this.guiders = {}; instead of var guiders = (function() { ... }) in order for guiders to attach to the window object more reliably. (Thanks @spmason 7229f66#commitcomment-2506855)
- Added bower support in component.json (Thanks rajkissu pickhardt#78)
- Added a method: guiders.getCurrentGuider, to get the current guider. This can be useful for analytics tracking, for example.
- guiders.next and guiders.prev return the value of guiders.getCurrent()
- Allow creating guidres in the HTML, then creating guiders via $("#guider2").guider(options).  The options can be passed in through options or set as data-attrs on the object in the HTML. (Thanks @tarr11 pickhardt#85)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rajkissu @pickhardt