Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FarCry 7.x support #64

Closed
justincarter opened this issue Mar 23, 2014 · 3 comments
Closed

FarCry 7.x support #64

justincarter opened this issue Mar 23, 2014 · 3 comments

Comments

@justincarter
Copy link
Contributor

In FarCry 7.x the configs are now stored as JSON instead of WDDX which means the FarCry Solr Pro configs won't save correctly.

There is also a couple of issues with CSS styles (e.g. applying a list style to the global "li" element), these should be easy to fix up.

I should be able to send a pull request for these fixes, I'm just in the process of forking and cloning now :)

@jeffcoughlin
Copy link
Owner

Thanks Justin.

Jeff

@jeffcoughlin
Copy link
Owner

Justin, will the updates make it no longer work in FC6 (both functionally and aesthetically)?

@justincarter
Copy link
Contributor Author

They should work for FC6 as well, I'll just check for WDDX and still
support that as well as JSON, and for the CSS it should work as-is
(hopefully I don't need to add a wrapping element).

cheers,
Justin

On Mon, Mar 24, 2014 at 10:33 AM, jeffcoughlin notifications@github.comwrote:

Justin, will the updates make it no longer work in FC6 (both functionally
and aesthetically)?

Reply to this email directly or view it on GitHubhttps://github.com//issues/64#issuecomment-38401780
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants