Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and cleanup. #12

Merged
merged 1 commit into from Oct 7, 2015
Merged

Refactoring and cleanup. #12

merged 1 commit into from Oct 7, 2015

Conversation

andreassjoberg
Copy link
Contributor

Made some methods static.
Removed unused references etc.

Made some methods static.
Removed unused references etc.
@jeffesp
Copy link
Owner

jeffesp commented Oct 7, 2015

I like that you cleaned up the using, don't mind the statics, but why did you change things like Int64 to long? Going to merge anyhow, just curious on that front.

jeffesp added a commit that referenced this pull request Oct 7, 2015
@jeffesp jeffesp merged commit b3bf4d5 into jeffesp:master Oct 7, 2015
@andreassjoberg
Copy link
Contributor Author

Hi,

I use ReSharper and it suggests using alias instead of type.
I'm sure you can google more on why it does that, I haven't really digged
into it that deep.

/ Andreas

On Wed, Oct 7, 2015, 17:02 Jeff Esp notifications@github.com wrote:

Merged #12 #12.


Reply to this email directly or view it on GitHub
#12 (comment).

@andreassjoberg andreassjoberg deleted the refactoring-and-cleanup branch October 8, 2015 06:53
@jeffesp
Copy link
Owner

jeffesp commented Oct 9, 2015

That's fine. Thanks for the pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants