Fixes #226

jeffharrell · Jul 25, 2014 · 73b1509 · 73b1509
1 parent 22412dc
commit 73b1509
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 18 deletions.
diff --git a/dist/minicart.js b/dist/minicart.js
@@ -2871,7 +2871,7 @@ View.prototype.addItem = function addItem(idx, data) {
     this.redraw();
     this.show();
 
-    var els = this.el.getElementsByClassName(constants.ITEM_CLASS);
+    var els = this.el.querySelectorAll('.' + constants.ITEM_CLASS);
     css.add(els[idx], constants.ITEM_CHANGED_CLASS);
 };
 
@@ -2886,7 +2886,7 @@ View.prototype.changeItem = function changeItem(idx, data) {
     this.redraw();
     this.show();
 
-    var els = this.el.getElementsByClassName(constants.ITEM_CLASS);
+    var els = this.el.querySelectorAll('.' + constants.ITEM_CLASS);
     css.add(els[idx], constants.ITEM_CHANGED_CLASS);
 };
 
@@ -3006,5 +3006,5 @@ module.exports = viewevents = {
 
 };
 
-},{"./constants":11,"./util/events":16}]},{},[9,10,11,12,13,14,15,16,17,18,19,20,21,22,23])
+},{"./constants":11,"./util/events":16}]},{},[9,11,10,12,13,14,15,16,17,18,19,20,21,22,23])
 ;
diff --git a/dist/minicart.min.js b/dist/minicart.min.js
diff --git a/src/view.js b/src/view.js
@@ -116,7 +116,7 @@ View.prototype.addItem = function addItem(idx, data) {
     this.redraw();
     this.show();
 
-    var els = this.el.getElementsByClassName(constants.ITEM_CLASS);
+    var els = this.el.querySelectorAll('.' + constants.ITEM_CLASS);
     css.add(els[idx], constants.ITEM_CHANGED_CLASS);
 };
 
@@ -131,7 +131,7 @@ View.prototype.changeItem = function changeItem(idx, data) {
     this.redraw();
     this.show();
 
-    var els = this.el.getElementsByClassName(constants.ITEM_CLASS);
+    var els = this.el.querySelectorAll('.' + constants.ITEM_CLASS);
     css.add(els[idx], constants.ITEM_CHANGED_CLASS);
 };
 

diff --git a/test/functional/view.js b/test/functional/view.js
@@ -47,9 +47,9 @@ function isCartShowing() {
 function getItem(idx) {
     var li, attrsList, attrsData = [], i, len;
 
-    if ((li = document.getElementsByClassName('minicart-item')[idx])) {
+    if ((li = document.querySelectorAll('.minicart-item')[idx])) {
 
-        attrsList = li.getElementsByClassName('minicart-attributes')[0];
+        attrsList = li.querySelectorAll('.minicart-attributes')[0];
         attrsList = attrsList && attrsList.getElementsByTagName('li');
 
         if (attrsList) {
@@ -60,8 +60,8 @@ function getItem(idx) {
 
         return {
             name: li.getElementsByTagName('a')[0].textContent.replace(/^\s+|\s+$/g, ''),
-            quantity: li.getElementsByClassName('minicart-quantity')[0].value,
-            amount: li.getElementsByClassName('minicart-price')[0].textContent.replace(/^\s+|\s+$/g, ''),
+            quantity: li.querySelectorAll('.minicart-quantity')[0].value,
+            amount: li.querySelectorAll('.minicart-price')[0].textContent.replace(/^\s+|\s+$/g, ''),
             options: attrsData
         };
     } else {
@@ -246,7 +246,7 @@ describe('View', function () {
 
         minicart.cart.add(mockData[0]);
 
-        input = document.getElementsByClassName('minicart-quantity')[0];
+        input = document.querySelectorAll('.minicart-quantity')[0];
         input.value = 3;
         fakeEvent(input, 'keyup');
 
@@ -262,7 +262,7 @@ describe('View', function () {
 
         minicart.cart.add(mockData[0]);
 
-        input = document.getElementsByClassName('minicart-quantity')[0];
+        input = document.querySelectorAll('.minicart-quantity')[0];
         input.value = '';
         fakeEvent(input, 'keyup');
 
@@ -278,7 +278,7 @@ describe('View', function () {
 
         minicart.cart.add(mockData[0]);
 
-        input = document.getElementsByClassName('minicart-quantity')[0];
+        input = document.querySelectorAll('.minicart-quantity')[0];
         input.value = 'asdf';
         fakeEvent(input, 'keyup');
 
@@ -293,7 +293,7 @@ describe('View', function () {
         minicart.cart.add(mockData[0]);
         assert(typeof getItem(0) === 'object');
 
-        fakeEvent(document.getElementsByClassName('minicart-remove')[0], 'click');
+        fakeEvent(document.querySelectorAll('.minicart-remove')[0], 'click');
         assert(getItem(0) === false);
     });
 
@@ -432,14 +432,14 @@ describe('View', function () {
         minicart.cart.add(mockData[0]);
         minicart.cart.add(mockData[1]);
 
-        assert(document.getElementsByClassName('minicart-subtotal')[0].textContent.replace(/^\s+|\s+$/g, '') === 'Subtotal: $5.00 USD');
+        assert(document.querySelectorAll('.minicart-subtotal')[0].textContent.replace(/^\s+|\s+$/g, '') === 'Subtotal: $5.00 USD');
     });
 
 
     it('should display a subtotal with correct currency', function () {
         minicart.cart.add(mockData[5]);
 
-        assert(document.getElementsByClassName('minicart-subtotal')[0].textContent.replace(/^\s+|\s+$/g, '') === 'Subtotal: €0.50');
+        assert(document.querySelectorAll('.minicart-subtotal')[0].textContent.replace(/^\s+|\s+$/g, '') === 'Subtotal: €0.50');
     });
 
 
@@ -462,7 +462,7 @@ describe('View', function () {
         minicart.cart.add(mockData[0]);
 
         cart = document.getElementById(config.name);
-        button = cart.getElementsByClassName('minicart-submit')[0];
+        button = cart.querySelectorAll('.minicart-submit')[0];
 
         assert(!!button);
     });
@@ -474,7 +474,7 @@ describe('View', function () {
         minicart.view.show();
 
         cart = document.getElementById(config.name);
-        button = cart.getElementsByClassName('minicart-submit')[0];
+        button = cart.querySelectorAll('.minicart-submit')[0];
 
         assert(!button);
     });