New parameter GenerateHttpTriggerUrlOutput #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll output the trigger url from the deployment template.
Splaxi
reviewed
Jul 7, 2019
| @@ -36,6 +36,9 @@ public class GeneratorCmdlet : PSCmdlet | |||
| [Parameter(Mandatory = false, HelpMessage = "If true, diagnostic settings will be included in the ARM template")] | |||
| public bool DiagnosticSettings = false; | |||
|
|
|||
| [Parameter(Mandatory = false, HelpMessage = "If true, generate an output variable with the trigger url.")] | |||
| public bool GenerateHttpTriggerUrlOutput = false; | |||
There was a problem hiding this comment.
May I suggest that you use the SwitchParameter type instead bool?
This will automatically be false when unset, but you only need to use the -GenerateHttpTriggerUrlOutput instead of -GenerateHttpTriggerUrlOutput:$true
I have suggested the same to DiagnosticSettings in PR #55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"If true, generate an output variable with the http trigger url."
This is a workaround for a problem (trigger does not exist) that occurs when the logic app template is linked from a "master template". Extracting the trigger url in the master template results in an error.
My theory is that trigger creation happens sometime after the logic app is deployed. Outputing the trigger url solves the problem.