Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve subscription disposal #6

Merged
merged 2 commits into from Aug 3, 2019

Conversation

@jeffijoe
Copy link
Owner

commented Aug 3, 2019

Better subscription disposal

This fixes an issue where, if a subscription is disposed,
it would not be attached to the Store anymore, and so disposing
the Store wouldn't wait for the subscription to finish.

Rename Position to ReadFrom

This is a breaking change, but since Snicket is pre-1.0, I only want to
trigger a minor bump. Once I have shipped a production application
using Snicket, 1.0 will be released.

jeffijoe added some commits Aug 3, 2019

fix: don't detach subscription until disposed
This fixes an issue where, if a subscription is disposed,
it would not be attached to the Store anymore, and so disposing
the Store wouldn't wait for the subscription to finish.
feat(ReadFrom): rename Position to ReadFrom
This is a breaking change, but since Snicket is pre-1.0, I only want to
trigger a minor bump. Once I have shipped a production application
using Snicket, 1.0 will be released.

@jeffijoe jeffijoe merged commit 4339e84 into master Aug 3, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@jeffijoe jeffijoe deleted the fix/zombie-disposals branch Aug 3, 2019

@jeffijoe

This comment has been minimized.

Copy link
Owner Author

commented Aug 3, 2019

🎉 This PR is included in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jeffijoe jeffijoe added the released label Aug 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.