Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display directory name in CLI output if `package.name` is absent #26

Merged
merged 1 commit into from Mar 16, 2019

Conversation

Projects
None yet
3 participants
@shroudedcode
Copy link
Contributor

shroudedcode commented Mar 10, 2019

First of all, great job on this package! It helps a lot with installing dependencies in TypeScript projects and the CLI output is really pretty.

However, I've found one small problem which is that when you don't specify a name in your project's package.json, the CLI output shows undefined:

If you're wondering why anyone would not specify a package name: It's simply redundant for "top-level packages" like back- or front-end codebases since they are not meant to be used as package dependencies.

My PR makes the package name fall back to the directory name which is helpful enough in most cases:

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 10, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 89b2562 on shroudedcode:package-name-fallback into 3952f8e on jeffijoe:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 10, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 89b2562 on shroudedcode:package-name-fallback into 3952f8e on jeffijoe:master.

@jeffijoe

This comment has been minimized.

Copy link
Owner

jeffijoe commented Mar 10, 2019

Good catch! Thanks for the PR!

I hope to have some time next week, I’ll release this with the other changes if I can get them done. 😀

@jeffijoe jeffijoe merged commit 4acdcb8 into jeffijoe:master Mar 16, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@shroudedcode shroudedcode deleted the shroudedcode:package-name-fallback branch Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.