Permalink
Browse files

Remove some completed TODOs from the codebase

  • Loading branch information...
jeffjenkins committed Dec 16, 2015
1 parent 61a3ea0 commit cb8ff1e687d5ef16dd1e8fdb0c97d898a232dee2
Showing with 0 additions and 8 deletions.
  1. +0 −2 exchange/exchange.go
  2. +0 −4 msgstore/msgstore.go
  3. +0 −1 server/connectionMethods.go
  4. +0 −1 server/server.go
View
@@ -96,8 +96,6 @@ func NewFromMethod(method *amqp.ExchangeDeclare, system bool, exchangeDeleter ch
var classId, methodId = method.MethodIdentifier()
var tp, err = ExchangeNameToType(method.Type)
if err != nil || tp == EX_TYPE_HEADERS {
// TODO: I should really make ChannelException and ConnectionException
// types
return nil, amqp.NewHardError(503, "Bad exchange type", classId, methodId)
}
var ex = NewExchange(
View
@@ -439,12 +439,8 @@ func decrIndexMessage(tx *bolt.Tx, id int64, ms *MessageStore) (int32, error) {
// decr then save or delete
if im.Refs < 1 {
panic("Index message would have gone negative!")
// TODO: isn't this a data integrity error?
index_bucket.Delete(bId)
return 0, nil
}
im.Refs -= 1
// TODO: panic on <0
if im.Refs == 0 {
ms.msgLock.Lock()
delete(ms.index, id)
@@ -61,7 +61,6 @@ func (channel *Channel) connectionTuneOk(conn *AMQPConnection, method *amqp.Conn
func (channel *Channel) connectionStartOk(conn *AMQPConnection, method *amqp.ConnectionStartOk) *amqp.AMQPError {
// TODO(SHOULD): record product/version/platform/copyright/information
// TODO(MUST): assert mechanism, response, locale are not null
// TODO(MUST): if the auth is wrong, send 403 access-refused
conn.connectStatus.startOk = true
if method.Mechanism != "PLAIN" {
View
@@ -100,7 +100,6 @@ func (server *Server) queueDeleteMonitor() {
}
}
// TODO: move most of this into the bindings file
func (server *Server) initBindings() {
// Load bindings
bindings, err := binding.LoadAllBindings(server.db)

0 comments on commit cb8ff1e

Please sign in to comment.