Skip to content

Conversation

@thejcannon
Copy link
Contributor

@thejcannon thejcannon commented Aug 11, 2023

This change adds a GitHub Action workflow file which is triggered on a push with a tag starting with release- which builds the sdist/wheel and publishes it to PyPI (leveraging PyPI's "Trusted Publishers" feature. Read more here).

Additionally:

  • Fixes a few errors that twine was upset about regarding the long_description
  • Removes the references/scripts to the manual release process.

Fixes #215

@thejcannon
Copy link
Contributor Author

I tested this out on the master branch of my fork, where I have these changes, plus I tweaked the name to icdiff-test and also changed the workflow to upload to https://test.pypi.org.

Here's the successful run: https://github.com/thejcannon/icdiff/actions/runs/5833953023/job/15822472910
Here's the test.pypi link: https://test.pypi.org/project/icdiff-test/#files

❗ Note that you have to go to https://pypi.org and configure this workflow as a "Trusted Publisher". This page describes how to do that.

Here's a screenshot of my settings from test.pypi.org for my dry-run (when it was pending before the publish):

Screenshot from 2023-08-11 09-59-24

@thejcannon
Copy link
Contributor Author

Please let me know any questions you have. I'd be more than willing to explain any and all of this 😄

Thanks again for your time <3

@jeffkaufman
Copy link
Owner

Thanks! Sorry for the slow responses; I've been traveling.

@jeffkaufman jeffkaufman merged commit 8cccd2c into jeffkaufman:master Aug 21, 2023
@thejcannon thejcannon deleted the jcannon/gha-release branch August 21, 2023 15:10
@thejcannon
Copy link
Contributor Author

No worries, I appreciate you taking a look.

And speaking of looking: https://pypi.org/project/icdiff/#files looks great!!

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish wheels for icdiff

2 participants