New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update players.txt #12

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@guoruibiao
Copy link
Collaborator

guoruibiao commented Jan 5, 2019

happy to join us.

Update players.txt
happy to join us.

@jmitchell jmitchell referenced this pull request Jan 5, 2019

Open

My thoughts and suggestions #17

0 of 6 tasks complete
@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 5, 2019

I'm ok with this going in, as long as you promise to submit a PR to remove yourself from players.txt if you get bored and want to stop playing.

(This is only needed until we have a fix for #19)

@TheJhyde TheJhyde self-requested a review Jan 5, 2019

@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 5, 2019

let's wait to sync and re-approve this until #11 has gone in

jeffkaufman added a commit that referenced this pull request Jan 6, 2019

players: switch to a directory
Currently, when new players are added that makes merge conflicts, and requires
a lot of re-approvals.  An easy way to avoid this is to use a directory instead
of a file.

Also add everyone who has asked to be added:
 * Closes #11
 * Closes #12
 * Closes #15
 * Closes #20
 * Closes #22

We should probably merge #23 first, so we don't get stuck if we lose someone
(#19).
@jeffkaufman

This comment has been minimized.

Copy link
Owner

jeffkaufman commented Jan 6, 2019

I'm ok with this going in once #23 and #26 are in

@TheJhyde TheJhyde added the Add Player label Jan 6, 2019

@tnelling tnelling closed this in #26 Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment