Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
approval-threshold: lower it daily after three days with no commits #23
Right now, if someone disappears then we'll have a draw; see #19. This change is a straight-forward way around this: once three days have passed without a commit, then for every additional day we require one fewer approver.
I'm open to other functions, but I'd like to get something in soon because we're adding a lot of players.
(I think this is probably not what we'll want long term.)
Fair enough. But nothing merging isn't the same thing as gameplay being hung, imo. If people are working on PRs, that's not accounted for, because this only checks against master.
Still, I'd probably be fine with letting the threshold drop after 3 days (though preferably longer I think) if people simply aren't approving or rejecting. In other words, turning abstention into approval (abstention being what we're trying to address). What I don't like is that this eventually turns rejections into approvals.
added a commit
this pull request
Jan 6, 2019
I'm fine with that, except that (a) it's much harder to code and (b) I really want to get something in soon before we add a lot more players. We don't have to stick with this.
referenced this pull request
Jan 6, 2019
Apparently, I hadn't had enough
I was voicing agreement with @tnelling's comment: